From: shiracha.rikyu@gmail•com
To: ruby-dev@ruby-lang.org
Subject: [ruby-dev:48536] [ruby-trunk - misc #10233] [Open] iseq.cのget_line_info()でバイナリサーチを使うように修正するか
Date: Fri, 12 Sep 2014 11:50:59 +0000 [thread overview]
Message-ID: <redmine.issue-10233.20140912115059.0c0dfb29557efd29@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-10233.20140912115059@ruby-lang.org
Issue #10233 has been reported by Rikyu Shiracha.
----------------------------------------
misc #10233: iseq.cのget_line_info()でバイナリサーチを使うように修正するか
https://bugs.ruby-lang.org/issues/10233
* Author: Rikyu Shiracha
* Status: Open
* Priority: Low
* Assignee:
* Category:
* Target version:
----------------------------------------
以下のPullRequestを投げさせていただきました。
https://github.com/ruby/ruby/pull/712
TODOコメントがあって気になったのでその通りの修正をとりあえず作ってみた形です。
ただむしろlinear searchのままにしておいて、コメントを
「ここは主にエラーハンドリングやデバッグに利用される部分でシンプルに保ちたいのでlinear searchを使っている」
という形に修正するべきかもしれない。とも思って迷っており、やはり辞めるべきかレビューを頂きたいです。
--
https://bugs.ruby-lang.org/
next parent reply other threads:[~2014-09-12 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-10233.20140912115059@ruby-lang.org>
2014-09-12 11:50 ` shiracha.rikyu [this message]
2014-09-12 12:21 ` [ruby-dev:48537] [ruby-trunk - misc #10233] iseq.cのget_line_info()でバイナリサーチを使うように修正するか ko1
2014-09-12 14:45 ` [ruby-dev:48539] " nobu
2014-09-13 6:49 ` [ruby-dev:48540] " shiracha.rikyu
2019-01-25 13:36 ` [ruby-dev:50771] [Ruby trunk Misc#10233] iseq.cのget_line_info()でバイナリサーチを使うように修正するか takashikkbn
2019-01-27 2:42 ` [ruby-dev:50774] " mame
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.issue-10233.20140912115059.0c0dfb29557efd29@ruby-lang.org \
--to=ruby-dev@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).