[ruby-dev:50026] [Ruby trunk Bug#13343] Improve Hash#merge performance

[ruby-dev:50026] [Ruby trunk Bug#13343] Improve Hash#merge performance

[watson1978]

Issue #13343 has been reported by watson1978 (Shizuo Fujita).

----------------------------------------
Bug #13343: Improve Hash#merge performance
https://bugs.ruby-lang.org/issues/13343

* Author: watson1978 (Shizuo Fujita)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
Hash#merge will be faster around 60%.

### Before
~~~
                 user     system      total        real
Hash#merge   0.160000   0.020000   0.180000 (  0.182357)
~~~

### After
~~~
                 user     system      total        real
Hash#merge   0.110000   0.010000   0.120000 (  0.114404)
~~~

### Test code
~~~
require 'benchmark'

Benchmark.bmbm do |x|
  hash1 = {}
  100.times { |i| hash1[i.to_s] = i }
  hash2 = {}
  100.times { |i| hash2[(i*2).to_s] = i*2 }

  x.report "Hash#merge" do
    10000.times do
      hash1.merge(hash2)
    end
  end
end
~~~

### Patch
The patch is in https://github.com/ruby/ruby/pull/1533



-- 
https://bugs.ruby-lang.org/

[ruby-dev:50046] Re: [Ruby trunk Bug#13343] Improve Hash#merge performance

[Eric Wong]

watson1978@gmail•com wrote:
> https://bugs.ruby-lang.org/issues/13343
> ----------------------------------------
> Hash#merge will be faster around 60%.

+Cc ruby-core, since your post was English (and I don't read Japanese)

This is promising!

> The patch is in https://github.com/ruby/ruby/pull/1533

We need to check for redefinition of initialize_dup and
initialize_copy methods in Hash for this to be correct.

Unfortunately for people optimizing Ruby, corner-case
redefinition checks are probably necessary :<

Also, I wonder if we can improve rb_funcall to better support
inline caching.  rb_funcall API is also bad since it cannot use
inline cache for method lookup.  Maybe a better C API can be
introduced for faster function calls from C.


Note: I checked commit c5d74afdb4cfea2a4c9ff432d9da82f0649a1e67
by having a "fetch = +refs/pull/*:refs/remotes/ruby/pull/*"
line in a "remote" section of my .git/config.  I did not
use any proprietary API or JavaScript to view your changes.

[ruby-dev:50047] [Ruby trunk Bug#13343] Improve Hash#merge performance

[watson1978]

Issue #13343 has been updated by watson1978 (Shizuo Fujita).


I followed the behavior of Array's methods such as

~~~
VALUE
rb_ary_sort(VALUE ary)
{
    ary = rb_ary_dup(ary);
~~~

It does not check whether initialize_dup/initialize_copy were overridden.


----------------------------------------
Bug #13343: Improve Hash#merge performance
https://bugs.ruby-lang.org/issues/13343#change-63850

* Author: watson1978 (Shizuo Fujita)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
Hash#merge will be faster around 60%.

### Before
~~~
                 user     system      total        real
Hash#merge   0.160000   0.020000   0.180000 (  0.182357)
~~~

### After
~~~
                 user     system      total        real
Hash#merge   0.110000   0.010000   0.120000 (  0.114404)
~~~

### Test code
~~~
require 'benchmark'

Benchmark.bmbm do |x|
  hash1 = {}
  100.times { |i| hash1[i.to_s] = i }
  hash2 = {}
  100.times { |i| hash2[(i*2).to_s] = i*2 }

  x.report "Hash#merge" do
    10000.times do
      hash1.merge(hash2)
    end
  end
end
~~~

### Patch
The patch is in https://github.com/ruby/ruby/pull/1533



-- 
https://bugs.ruby-lang.org/