[ruby-core:110513] [Ruby master Feature#19083] Add `node_id_for_location` to ast.c

[ruby-core:110513] [Ruby master Feature#19083] Add `node_id_for_location` to ast.c

[eileencodes (Eileen Uchitelle)]

Issue #19083 has been reported by eileencodes (Eileen Uchitelle).

----------------------------------------
Feature #19083: Add `node_id_for_location` to ast.c
https://bugs.ruby-lang.org/issues/19083

* Author: eileencodes (Eileen Uchitelle)
* Status: Open
* Priority: Normal
----------------------------------------
Opening a ticket to get public comments on https://github.com/ruby/ruby/pull/6593. I worked on this with Aaron Patterson.

We want to use error highlight with eval'd code, specifically ERB templates. We're able to recover the generated code for eval'd templates and can get a parse tree for the ERB generated code, but we don't have a way to get the node id from the backtrace location. So we can't pass the right node into error highlight.

This patch gives us an API to get the node id from the backtrace location so we can find the node in the AST.

This change is needed for column info in ERB templates that Aaron worked on here https://github.com/rails/rails/pull/46171. Without this change we need to set `RubyVM.keep_script_lines = true`. With the changes here we should be able to remove keep_script_lines.



-- 
https://bugs.ruby-lang.org/

[ruby-core:110544] [Ruby master Feature#19083] Add `node_id_for_backtrace_location` to ast.c

[eileencodes (Eileen Uchitelle)]

Issue #19083 has been updated by eileencodes (Eileen Uchitelle).

File 0001-Add-node_id_for_backtrace_location-function.patch added
Subject changed from Add `node_id_for_location` to ast.c to Add `node_id_for_backtrace_location` to ast.c

I've update the function name from node_id_for_location to node_id_for_backtrace_location. Also I attached the patch here.

----------------------------------------
Feature #19083: Add `node_id_for_backtrace_location` to ast.c
https://bugs.ruby-lang.org/issues/19083#change-99873

* Author: eileencodes (Eileen Uchitelle)
* Status: Open
* Priority: Normal
----------------------------------------
Opening a ticket to get public comments on https://github.com/ruby/ruby/pull/6593. I worked on this with Aaron Patterson.

We want to use error highlight with eval'd code, specifically ERB templates. We're able to recover the generated code for eval'd templates and can get a parse tree for the ERB generated code, but we don't have a way to get the node id from the backtrace location. So we can't pass the right node into error highlight.

This patch gives us an API to get the node id from the backtrace location so we can find the node in the AST.

This change is needed for column info in ERB templates that Aaron worked on here https://github.com/rails/rails/pull/46171. Without this change we need to set `RubyVM.keep_script_lines = true`. With the changes here we should be able to remove keep_script_lines.

---Files--------------------------------
0001-Add-node_id_for_backtrace_location-function.patch (3.07 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:110550] [Ruby master Feature#19083] Add `node_id_for_backtrace_location` to ast.c

[matz (Yukihiro Matsumoto)]

Issue #19083 has been updated by matz (Yukihiro Matsumoto).


Sounds OK. Please merge.

Matz.


----------------------------------------
Feature #19083: Add `node_id_for_backtrace_location` to ast.c
https://bugs.ruby-lang.org/issues/19083#change-99878

* Author: eileencodes (Eileen Uchitelle)
* Status: Open
* Priority: Normal
----------------------------------------
Opening a ticket to get public comments on https://github.com/ruby/ruby/pull/6593. I worked on this with Aaron Patterson.

We want to use error highlight with eval'd code, specifically ERB templates. We're able to recover the generated code for eval'd templates and can get a parse tree for the ERB generated code, but we don't have a way to get the node id from the backtrace location. So we can't pass the right node into error highlight.

This patch gives us an API to get the node id from the backtrace location so we can find the node in the AST.

This change is needed for column info in ERB templates that Aaron worked on here https://github.com/rails/rails/pull/46171. Without this change we need to set `RubyVM.keep_script_lines = true`. With the changes here we should be able to remove keep_script_lines.

---Files--------------------------------
0001-Add-node_id_for_backtrace_location-function.patch (3.07 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:110553] [Ruby master Feature#19083] Add `node_id_for_backtrace_location` to ast.c

[mame (Yusuke Endoh)]

Issue #19083 has been updated by mame (Yusuke Endoh).

Status changed from Open to Closed

Thank you all! I have merged the PR at commit:3391c51effcd61f9a718adf59740661d99f57b5b

----------------------------------------
Feature #19083: Add `node_id_for_backtrace_location` to ast.c
https://bugs.ruby-lang.org/issues/19083#change-99881

* Author: eileencodes (Eileen Uchitelle)
* Status: Closed
* Priority: Normal
----------------------------------------
Opening a ticket to get public comments on https://github.com/ruby/ruby/pull/6593. I worked on this with Aaron Patterson.

We want to use error highlight with eval'd code, specifically ERB templates. We're able to recover the generated code for eval'd templates and can get a parse tree for the ERB generated code, but we don't have a way to get the node id from the backtrace location. So we can't pass the right node into error highlight.

This patch gives us an API to get the node id from the backtrace location so we can find the node in the AST.

This change is needed for column info in ERB templates that Aaron worked on here https://github.com/rails/rails/pull/46171. Without this change we need to set `RubyVM.keep_script_lines = true`. With the changes here we should be able to remove keep_script_lines.

---Files--------------------------------
0001-Add-node_id_for_backtrace_location-function.patch (3.07 KB)


-- 
https://bugs.ruby-lang.org/