From: "stanhu (Stan Hu)" <noreply@ruby-lang.org>
To: ruby-core@ruby-lang.org
Subject: [ruby-core:110029] [Ruby master Feature#19018] uri/generic: Support comma-delimited entries in no_proxy
Date: Fri, 23 Sep 2022 05:08:48 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-99279.20220923050848.13608@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-19018.20220923044638.13608@ruby-lang.org
Issue #19018 has been updated by stanhu (Stan Hu).
I submitted https://github.com/ruby/ruby/pull/6424. That method could use some cleanup.
----------------------------------------
Feature #19018: uri/generic: Support comma-delimited entries in no_proxy
https://bugs.ruby-lang.org/issues/19018#change-99279
* Author: stanhu (Stan Hu)
* Status: Open
* Priority: Normal
----------------------------------------
Currently `URI::Generic.use_proxy?` does not treat the `no_proxy` strings as a comma-delimited value: https://github.com/ruby/ruby/blob/0ed71b37fa9af134fdd5a7fd1cebd171eba83541/lib/uri/generic.rb#L1545-L1564
That means that it's not possible to specify multiple rules, such as:
```
no_proxy=.example.com,192.168.0.0/8
```
While there's no official standard for `no_proxy`(https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/), [Python](https://github.com/python/cpython/blob/030a713183084594659aefd77b76fe30178e23c8/Lib/urllib/request.py#L2540) and [Golang](https://github.com/golang/go/blob/682a1d2176b02337460aeede0ff9e49429525195/src/vendor/golang.org/x/net/http/httpproxy/proxy.go#L216) split the comma.
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2022-09-23 5:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 4:46 [ruby-core:110028] [Ruby master Feature#19018] uri/generic: Support comma-delimited entries in no_proxy stanhu (Stan Hu)
2022-09-23 5:08 ` stanhu (Stan Hu) [this message]
2022-09-23 5:25 ` [ruby-core:110030] [Ruby master Feature#19018] uri/generic: Support CIDR blocks in " stanhu (Stan Hu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-99279.20220923050848.13608@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).