From: "nobu (Nobuyoshi Nakada)" <noreply@ruby-lang.org>
To: ruby-core@ruby-lang.org
Subject: [ruby-core:106432] [Ruby master Feature#18253] `ID` in `rb_id_table_foreach_with_replace`
Date: Fri, 03 Dec 2021 03:08:51 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-95075.20211203030850.4@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-18253.20211018062201.4@ruby-lang.org
Issue #18253 has been updated by nobu (Nobuyoshi Nakada).
Which patch, passing the ID, or removing ID argument?
----------------------------------------
Feature #18253: `ID` in `rb_id_table_foreach_with_replace`
https://bugs.ruby-lang.org/issues/18253#change-95075
* Author: nobu (Nobuyoshi Nakada)
* Status: Assigned
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
----------------------------------------
`rb_id_table_foreach_with_replace` doesn't pass the `ID` to `func` and `replace`.
If this is intensional, `func` should be `rb_id_table_foreach_values_func_t` and `rb_id_table_update_callback_func_t` doesn't need the `id` argument?
Or should the function pass the `ID`?
```diff
diff --git a/id_table.c b/id_table.c
index b2ba6fae89e..281a0fb50a7 100644
--- a/id_table.c
+++ b/id_table.c
@@ -274,12 +274,14 @@ rb_id_table_foreach_with_replace(struct rb_id_table *tbl, rb_id_table_foreach_fu
for (i=0; i<capa; i++) {
if (ITEM_KEY_ISSET(tbl, i)) {
- enum rb_id_table_iterator_result ret = (*func)((ID)0, tbl->items[i].val, data);
- assert(ITEM_GET_KEY(tbl, i));
+ const id_key_t key = ITEM_GET_KEY(tbl, i);
+ ID id = key2id(key);
+ enum rb_id_table_iterator_result ret = (*func)(id, tbl->items[i].val, data);
+ assert(key != 0);
if (ret == ID_TABLE_REPLACE) {
VALUE val = tbl->items[i].val;
- ret = (*replace)(NULL, &val, data, TRUE);
+ ret = (*replace)(&id, &val, data, TRUE);
tbl->items[i].val = val;
}
else if (ret == ID_TABLE_STOP)
```
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2021-12-03 3:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 6:22 [ruby-core:105658] [Ruby master Misc#18253] `ID` in `rb_id_table_foreach_with_replace` nobu (Nobuyoshi Nakada)
2021-10-18 6:29 ` [ruby-core:105659] " nobu (Nobuyoshi Nakada)
2021-12-02 20:55 ` [ruby-core:106417] " tenderlovemaking (Aaron Patterson)
2021-12-03 3:08 ` nobu (Nobuyoshi Nakada) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-95075.20211203030850.4@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).