[ruby-core:105805] [Ruby master Bug#18270] Refinement#{extend_object, append_features, prepend_features} should be removed

[ruby-core:105805] [Ruby master Bug#18270] Refinement#{extend_object, append_features, prepend_features} should be removed

[shugo (Shugo Maeda)]

Issue #18270 has been reported by shugo (Shugo Maeda).

----------------------------------------
Bug #18270: Refinement#{extend_object,append_features,prepend_features} should be removed
https://bugs.ruby-lang.org/issues/18270

* Author: shugo (Shugo Maeda)
* Status: Assigned
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
Refinement#{extend_object,append_features,prepend_features} are not useful and should be removed.

How about to deprecate them in Ruby 3.1 and remove in Ruby 3.1?




-- 
https://bugs.ruby-lang.org/

[ruby-core:106106] [Ruby master Feature#18270] Refinement#{extend_object, append_features, prepend_features} should be removed

[shugo (Shugo Maeda)]

Issue #18270 has been updated by shugo (Shugo Maeda).


These methods raise ArgumentError since #13236 was fixed, so it may not be necessary to remove them.


----------------------------------------
Feature #18270: Refinement#{extend_object,append_features,prepend_features} should be removed
https://bugs.ruby-lang.org/issues/18270#change-94695

* Author: shugo (Shugo Maeda)
* Status: Assigned
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
----------------------------------------
Refinement#{extend_object,append_features,prepend_features} are not useful and should be removed.

How about to deprecate them in Ruby 3.1 and remove in Ruby 3.1?




-- 
https://bugs.ruby-lang.org/

[ruby-core:106107] [Ruby master Feature#18270] Refinement#{extend_object, append_features, prepend_features} should be removed

[shugo (Shugo Maeda)]

Issue #18270 has been updated by shugo (Shugo Maeda).


append_features is undefined in the class Class, and Module#include raises TypeError before calling append_features if the given argument is a Class.


----------------------------------------
Feature #18270: Refinement#{extend_object,append_features,prepend_features} should be removed
https://bugs.ruby-lang.org/issues/18270#change-94696

* Author: shugo (Shugo Maeda)
* Status: Assigned
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
----------------------------------------
Refinement#{extend_object,append_features,prepend_features} are not useful and should be removed.

How about to deprecate them in Ruby 3.1 and remove in Ruby 3.1?




-- 
https://bugs.ruby-lang.org/

[ruby-core:106117] [Ruby master Feature#18270] Refinement#{extend_object, append_features, prepend_features} should be removed

[shugo (Shugo Maeda)]

Issue #18270 has been updated by shugo (Shugo Maeda).

Assignee changed from matz (Yukihiro Matsumoto) to shugo (Shugo Maeda)

At the developers meeting on 2011-11-18, Matz accepted the following changes in Ruby 3.2:

* Undefine extend_object, append_features, prepend_features in Refinement.
* extend, include, and prepend raise a TypeError if the given argument is a Refinement as in the case the argument is a Class.

No warnings will be added in Ruby 3.1, because append_features etc. currently already raises ArgumentError.

```
excelsior:ruby$ ruby -e 'class Foo; end; module Bar; refine Integer do append_features(Foo); end; end'
-e:1:in `append_features': refinement module is not allowed (ArgumentError)
        from -e:1:in `block in <module:Bar>'
        from -e:1:in `refine'
        from -e:1:in `<module:Bar>'
        from -e:1:in `<main>'
```


----------------------------------------
Feature #18270: Refinement#{extend_object,append_features,prepend_features} should be removed
https://bugs.ruby-lang.org/issues/18270#change-94714

* Author: shugo (Shugo Maeda)
* Status: Assigned
* Priority: Normal
* Assignee: shugo (Shugo Maeda)
----------------------------------------
Refinement#{extend_object,append_features,prepend_features} are not useful and should be removed.

How about to deprecate them in Ruby 3.1 and remove in Ruby 3.1?




-- 
https://bugs.ruby-lang.org/

[ruby-core:106131] [Ruby master Feature#18270] Refinement#{extend_object, append_features, prepend_features} should be removed

[Eregon (Benoit Daloze)]

Issue #18270 has been updated by Eregon (Benoit Daloze).


Sounds good.
Could you please add tests in ruby/spec to track those changes, under `core/refinement`?
The structure can be generated with `../mspec/bin/mkspec -b core -c Refinement`.

----------------------------------------
Feature #18270: Refinement#{extend_object,append_features,prepend_features} should be removed
https://bugs.ruby-lang.org/issues/18270#change-94729

* Author: shugo (Shugo Maeda)
* Status: Assigned
* Priority: Normal
* Assignee: shugo (Shugo Maeda)
----------------------------------------
Refinement#{extend_object,append_features,prepend_features} are not useful and should be removed.

How about to deprecate them in Ruby 3.1 and remove in Ruby 3.1?




-- 
https://bugs.ruby-lang.org/

[ruby-core:106165] [Ruby master Feature#18270] Refinement#{extend_object, append_features, prepend_features} should be removed

[shugo (Shugo Maeda)]

Issue #18270 has been updated by shugo (Shugo Maeda).


Eregon (Benoit Daloze) wrote in #note-6:
> Sounds good.

Thanks.

> Could you please add tests in ruby/spec to track those changes, under `core/refinement`?
> The structure can be generated with `../mspec/bin/mkspec -b core -c Refinement`.

OK, I'll add tests after implementing these changes after the release of Ruby 3.1.

----------------------------------------
Feature #18270: Refinement#{extend_object,append_features,prepend_features} should be removed
https://bugs.ruby-lang.org/issues/18270#change-94768

* Author: shugo (Shugo Maeda)
* Status: Assigned
* Priority: Normal
* Assignee: shugo (Shugo Maeda)
----------------------------------------
Refinement#{extend_object,append_features,prepend_features} are not useful and should be removed.

How about to deprecate them in Ruby 3.1 and remove in Ruby 3.1?




-- 
https://bugs.ruby-lang.org/

[ruby-core:106844] [Ruby master Feature#18270] Refinement#{extend_object, append_features, prepend_features} should be removed

[jeremyevans0 (Jeremy Evans)]

Issue #18270 has been updated by jeremyevans0 (Jeremy Evans).


I've submitted a pull request to implement this: https://github.com/ruby/ruby/pull/5358

----------------------------------------
Feature #18270: Refinement#{extend_object,append_features,prepend_features} should be removed
https://bugs.ruby-lang.org/issues/18270#change-95655

* Author: shugo (Shugo Maeda)
* Status: Assigned
* Priority: Normal
* Assignee: shugo (Shugo Maeda)
----------------------------------------
Refinement#{extend_object,append_features,prepend_features} are not useful and should be removed.

How about to deprecate them in Ruby 3.1 and remove in Ruby 3.1?




-- 
https://bugs.ruby-lang.org/

[ruby-core:106971] [Ruby master Feature#18270] Refinement#{extend_object, append_features, prepend_features} should be removed

[shugo (Shugo Maeda)]

Issue #18270 has been updated by shugo (Shugo Maeda).


jeremyevans0 (Jeremy Evans) wrote in #note-8:
> I've submitted a pull request to implement this: https://github.com/ruby/ruby/pull/5358

Thank you.  I've approved it, but it has conflicts with my commits....
Could you merge it resolving conflicts?


----------------------------------------
Feature #18270: Refinement#{extend_object,append_features,prepend_features} should be removed
https://bugs.ruby-lang.org/issues/18270#change-95799

* Author: shugo (Shugo Maeda)
* Status: Assigned
* Priority: Normal
* Assignee: shugo (Shugo Maeda)
----------------------------------------
Refinement#{extend_object,append_features,prepend_features} are not useful and should be removed.

How about to deprecate them in Ruby 3.1 and remove in Ruby 3.1?




-- 
https://bugs.ruby-lang.org/