From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id C6D741F9F4 for ; Fri, 17 Sep 2021 09:48:20 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id B6F65120BA7; Fri, 17 Sep 2021 18:46:55 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id CBCA2120BA8 for ; Fri, 17 Sep 2021 18:46:52 +0900 (JST) Received: by filterdrecv-55446c4d49-kv7js with SMTP id filterdrecv-55446c4d49-kv7js-1-61446459-45 2021-09-17 09:48:09.813800116 +0000 UTC m=+1337262.456894291 Received: from herokuapp.com (unknown) by ismtpd0171p1iad2.sendgrid.net (SG) with ESMTP id cevX7zooQx6PVWMVmoIiDA for ; Fri, 17 Sep 2021 09:48:09.800 +0000 (UTC) Date: Fri, 17 Sep 2021 09:48:09 +0000 (UTC) From: "shugo (Shugo Maeda)" Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17429 X-Redmine-Issue-Author: shugo X-Redmine-Issue-Assignee: matz X-Redmine-Sender: shugo X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 81502 X-SG-EID: =?us-ascii?Q?o0C=2FsDUd4ZFGiDZCTbvVjqibxcpCfydz4lwnBQWyXZ+Plw=2FfhrG0CQPbrktOPX?= =?us-ascii?Q?NfKIrb7bilCwkXET66DNxoLxfX42U48LTRbe1pE?= =?us-ascii?Q?v5fyrHKIzzX+fCRJy8ksYN2GYaNUBTFonaH7GOb?= =?us-ascii?Q?QblkMfv1nTvO0xTdVEHb7G0QQh0p3Y+YqIGeM+2?= =?us-ascii?Q?qCAo+WVovSDAHvdbn3P51U5Za119gI6vpIYwJiw?= =?us-ascii?Q?91n+2B340lwEJydEgWhF7u80jiO9Fgd5xfKZcw9?= =?us-ascii?Q?EEoclSR5R8HPVOlemAebQ=3D=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 105326 Subject: [ruby-core:105326] [Ruby master Bug#17429] Prohibit include/prepend in refinement modules X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17429 has been updated by shugo (Shugo Maeda). shugo (Shugo Maeda) wrote in #note-31: > mame (Yusuke Endoh) wrote in #note-30: > > BTW, the change seems to add a top-level new constant `::Refinement`. I'm not against the addition, but unsure about the impact. Is it okay? > > I found a gem named refinement.... > > https://github.com/square/refinement/blob/master/lib/refinement.rb I've created an issue on the project: . By gem-codesearch, I've found another gem which defines ::Refinement. * https://github.com/rkh/refine/blob/master/lib/refine.rb However, it's a gem for very old Ruby versions without Refinements, so I believe there's no problem. ---------------------------------------- Bug #17429: Prohibit include/prepend in refinement modules https://bugs.ruby-lang.org/issues/17429#change-93740 * Author: shugo (Shugo Maeda) * Status: Open * Priority: Normal * Assignee: matz (Yukihiro Matsumoto) * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- include/prepend in refinement modules has implementation difficulties such as #17007 and #17379, and tends to be misleading like #17374. How about to prohibit it in future versions? Method copy like #17380 may be more convenient, but it's confusing to use names include and prepend because semantics is different from the original ones. -- https://bugs.ruby-lang.org/