From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id E21C71F8C6 for ; Sat, 7 Aug 2021 20:35:21 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id C34231208C7; Sun, 8 Aug 2021 05:33:59 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 4462A1208C7 for ; Sun, 8 Aug 2021 05:33:58 +0900 (JST) Received: by filterdrecv-577766fbc8-fpnxz with SMTP id filterdrecv-577766fbc8-fpnxz-1-610EEE81-A 2021-08-07 20:35:13.3537311 +0000 UTC m=+1045027.556787669 Received: from herokuapp.com (unknown) by ismtpd0154p1iad2.sendgrid.net (SG) with ESMTP id M4FV2_UeRNGQ-KTqipet9A for ; Sat, 07 Aug 2021 20:35:13.333 +0000 (UTC) Date: Sat, 07 Aug 2021 20:35:13 +0000 (UTC) From: v.ondruch@tiscali.cz Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 18066 X-Redmine-Issue-Author: vo.x X-Redmine-Sender: vo.x X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 80964 X-SG-EID: =?us-ascii?Q?mWhqNvD1xlBozk4zn6CTHlnSPHlTKkyHJdiOH=2FzC52hkH1ggnB6mlF2kSVkfQo?= =?us-ascii?Q?byZntD8NhcOmXGcMUNxuUUlsOi=2FF71j=2FEGC51l4?= =?us-ascii?Q?jyTRmDH4Fwyw4FTU681gfU1HPTapjXdtVd9iy29?= =?us-ascii?Q?14VHFOCkB7UbeSNUDeOsj9SGWXr4TtnkTnWG438?= =?us-ascii?Q?CcO5olFy8aLTkOKj64cAwVwLsGAHvOMnHwg=3D=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 104832 Subject: [ruby-core:104832] [Ruby master Bug#18066] Load did_you_mean eve/error_highlight even with --disable-gems X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #18066 has been updated by vo.x (Vit Ondruch). However, I am not sure what is the impact in case Ruby can be build with `--disable-gems` configuration option (if that is possible). ---------------------------------------- Bug #18066: Load did_you_mean eve/error_highlight even with --disable-gems https://bugs.ruby-lang.org/issues/18066#change-93173 * Author: vo.x (Vit Ondruch) * Status: Open * Priority: Normal * ruby -v: ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-linux] * Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN ---------------------------------------- I guess that did_you_mean was not possible to load without RubyGems, when it used to be bundled gem. Since it is default gem, therefore part of StdLib and always available on load path, it should not be related to --disable-gems anymore. IOW ruby.c contains this code: ~~~ruby if (opt->features.set & FEATURE_BIT(gems)) { rb_define_module("Gem"); if (opt->features.set & FEATURE_BIT(error_highlight)) { rb_define_module("ErrorHighlight"); } if (opt->features.set & FEATURE_BIT(did_you_mean)) { rb_define_module("DidYouMean"); } } ~~~ while it should look like: ~~~ if (opt->features.set & FEATURE_BIT(gems)) { rb_define_module("Gem"); } if (opt->features.set & FEATURE_BIT(error_highlight)) { rb_define_module("ErrorHighlight"); } if (opt->features.set & FEATURE_BIT(did_you_mean)) { rb_define_module("DidYouMean"); } ~~~ (I have not checked error_highlight, but I assume it behaves similarly to did_you_mean) -- https://bugs.ruby-lang.org/