From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 54B131F5AE for ; Fri, 21 May 2021 19:11:52 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 26E6A120E10; Sat, 22 May 2021 04:10:44 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id CCFFE120B22 for ; Sat, 22 May 2021 04:10:41 +0900 (JST) Received: by filterdrecv-79b6969b64-2gg4p with SMTP id filterdrecv-79b6969b64-2gg4p-1-60A805F1-87 2021-05-21 19:11:45.737005179 +0000 UTC m=+1298481.347255328 Received: from herokuapp.com (unknown) by geopod-ismtpd-4-0 (SG) with ESMTP id 2ai9JSvySLaB8d1_otmgyQ for ; Fri, 21 May 2021 19:11:45.652 +0000 (UTC) Date: Fri, 21 May 2021 19:11:45 +0000 (UTC) From: merch-redmine@jeremyevans.net Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 16983 X-Redmine-Issue-Author: pocke X-Redmine-Issue-Assignee: ko1 X-Redmine-Sender: jeremyevans0 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 80004 X-SG-EID: =?us-ascii?Q?RVE3t853K5scBhbmJHUzZTFFeVC=2FZSUmHZ0Dc+26wcEi2CTgsF1oz0wTSSxGGN?= =?us-ascii?Q?BICmp8EDdKjGDbC8kBNBEQIfmNkbuutvsbUxaVD?= =?us-ascii?Q?OhjTLEamOdUW2iitfX2RC3GxlysROrWRd4254sm?= =?us-ascii?Q?5yfgVXXin4lA5qK7zwRFH9dodNiKOucsYpjWvi9?= =?us-ascii?Q?1OP7yk9j4fUZQADabDdD3Bojq+P+XKzRMfgp3h0?= =?us-ascii?Q?OgqCc9oroI6aCAumQ=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 103957 Subject: [ruby-core:103957] [Ruby master Bug#16983] RubyVM::AbstractSyntaxTree.of(method) returns meaningless node if the method is defined in eval X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16983 has been updated by jeremyevans0 (Jeremy Evans). Because I know how busy @ko1 is, I thought I'd save him some work and tried to implement this myself: https://github.com/ruby/ruby/pull/4519 ---------------------------------------- Bug #16983: RubyVM::AbstractSyntaxTree.of(method) returns meaningless node if the method is defined in eval https://bugs.ruby-lang.org/issues/16983#change-92089 * Author: pocke (Masataka Kuwabara) * Status: Assigned * Priority: Normal * Assignee: ko1 (Koichi Sasada) * ruby -v: ruby 2.8.0dev (2020-06-23T13:58:26Z master dc351ff984) [x86_64-linux] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- # Problem `RubyVM::AST.of(method)` returns a meaningless node if the method is defined in eval. For example: ```ruby p 'blah' eval <<~RUBY, binding, __FILE__, __LINE__ + 1 def foo end RUBY method = method(:foo) pp RubyVM::AbstractSyntaxTree.of(method) # => (STR@3:5-3:12 "def foo\n" + "end\n") ``` I expect the node of `foo` method, or `nil`. But it returns a `STR` node. It becomes a big problem when `AST.of` receives arbitrary methods. Because we can't distinguish a method is defined in `eval` or not. It means we can't believe the returned value of `AST.of` if the method may receive a method defined in `eval`. For example: ```ruby def do_something_for_each_method_ast(klass) klass.instance_methods(false).each do |m| ast = RubyVM::AbstractSyntaxTree.of(klass.instance_method(m)) next unless ast do_something ast end end class A eval <<~RUBY, binding, __FILE__, __LINE__ + 1 def foo end RUBY end do_something_for_each_method_ast A ``` In the example, I expect the `do_something` method receives only node for a method definition, but it may pass a wrong node if any method is defined in `eval`. # Cause (I guess) I guess the cause is misleading node number. In and out of an `eval` block uses different sequences of node number. So if I specify `__FILE__` to `eval`, the actual file and code in `eval` may have the same node number. For example ```ruby p 'blah' # Node number for 'blah' is 1, file name is "test.rb" eval <<~RUBY, binding, __FILE__, __LINE__ + 1 def foo # Node number for `def` is also 1, file name is also "test.rb" end RUBY method = method(:foo) # It finds a node from node number 1 by reading "test.rb", so it get the str node. pp RubyVM::AbstractSyntaxTree.of(method) # => (STR@3:5-3:12 "def foo\n" + "end\n") ``` -- https://bugs.ruby-lang.org/