From: merch-redmine@jeremyevans.net
To: ruby-core@ruby-lang.org
Subject: [ruby-core:103838] [Ruby master Bug#17493] Calling Reline::Unicode.calculate_width appears to lock up when called from emacs or if output is redirected
Date: Thu, 13 May 2021 21:54:25 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-91957.20210513215424.47734@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-17493.20201231063007.47734@ruby-lang.org
Issue #17493 has been updated by jeremyevans0 (Jeremy Evans).
The provided patch appears to only affect Windows, but I confirmed the problem also happens on OpenBSD. Presumably it happens on other operating systems too. I added a similar fix of using GeneralIO for the non-Windows case, and submitted a pull request to reline for it: https://github.com/ruby/reline/pull/285
----------------------------------------
Bug #17493: Calling Reline::Unicode.calculate_width appears to lock up when called from emacs or if output is redirected
https://bugs.ruby-lang.org/issues/17493#change-91957
* Author: rsharman (Richard Sharman)
* Status: Open
* Priority: Normal
* ruby -v: ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-darwin17]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
In https://github.com/ruby/reline/pull/224 there is a test program
```
require "reline"
p Reline::Unicode.calculate_width("√")
```
as a test case for bug #17405. This program hangs when called from an emacs shell.
The problem is that cursor_pos in reline/ansi.rb outputs ESC [ 6 n and expects to be able read in raw mode the cursor position. This doesn't work when ruby is invoked from a shell inside emacs.
```
--> #1 /Users/richard/.rbenv/versions/3.0/lib/ruby/3.0.0/reline/ansi.rb:175:in `cursor_pos'
#2 /Users/richard/.rbenv/versions/3.0/lib/ruby/3.0.0/reline.rb:373:in `may_req_ambiguous_char_width'
#3 /Users/richard/.rbenv/versions/3.0/lib/ruby/3.0.0/reline.rb:359:in `ambiguous_width'
#4 /Users/richard/.rbenv/versions/3.0/lib/ruby/3.0.0/forwardable.rb:238:in `ambiguous_width'
#5 /Users/richard/.rbenv/versions/3.0/lib/ruby/3.0.0/reline/unicode.rb:115:in `get_mbchar_width'
#6 /Users/richard/.rbenv/versions/3.0/lib/ruby/3.0.0/reline/unicode.rb:143:in `calculate_width'
#7 /Users/richard/rubystuff/bugs/cursor_pos/test.rb:4
```
Even when run from an actual terminal, a similar problem occurs if stdout is redirected:
```
$ ruby test2.rb > T
```
The program appears to have locked up at this point; pressing Control-C will not terminate it.
Is it valid for a routine that calculates a character's width to assume that stdin is actually an ANSI sequence compatible terminal?
(This also occurs with ruby version 2.7.2p137.)
---Files--------------------------------
test.rb (75 Bytes)
Patch (609 Bytes)
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2021-05-13 21:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 6:30 [ruby-core:101829] [Ruby master Bug#17493] Calling Reline::Unicode.calculate_width appears to lock up when called from emacs or if output is redirected rsharman
2021-01-07 20:34 ` [ruby-core:101977] " rsharman
2021-05-13 21:54 ` merch-redmine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-91957.20210513215424.47734@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).