From: dylan.smith@shopify.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:103534] [Ruby master Bug#14607] Fix use of the rb_profile_frames start parameter
Date: Tue, 20 Apr 2021 21:59:24 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-91635.20210420215923.13791@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-14607.20180315145539.13791@ruby-lang.org
Issue #14607 has been updated by dylants (Dylan Thacker-Smith).
> I need to remember why such special (additional) calculation is done
I'm not sure what you mean by additional calculation. It is decrementing `start` when non-zero as expected to loop over that number of frames, it just was missing the corresponding update to `cfp`.
Could this get another look?
----------------------------------------
Bug #14607: Fix use of the rb_profile_frames start parameter
https://bugs.ruby-lang.org/issues/14607#change-91635
* Author: dylants (Dylan Thacker-Smith)
* Status: Open
* Priority: Normal
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
rb_profile_frames was always behaving as if the value given for the start parameter was 0.
The reason for this was that it would check `if (start > 0) {` then `continue` without updating the control frame pointer or anything other than decrementing `start`.
This bug applies to all branches under normal maintenance, from ruby 2.3 to trunk.
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2021-04-20 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-14607.20180315145539.13791@ruby-lang.org>
2020-08-04 19:57 ` [ruby-core:99479] [Ruby master Bug#14607] Fix use of the rb_profile_frames start parameter dylan.smith
2021-04-20 21:59 ` dylan.smith [this message]
2022-06-09 6:12 ` [ruby-core:108815] " mame (Yusuke Endoh)
2024-01-16 18:14 ` [ruby-core:116233] " dylants (Dylan Thacker-Smith) via ruby-core
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-91635.20210420215923.13791@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).