From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 649181F4B4 for ; Fri, 2 Apr 2021 14:49:45 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id E2944120A1E; Fri, 2 Apr 2021 23:48:42 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 39FAE120A1D for ; Fri, 2 Apr 2021 23:48:40 +0900 (JST) Received: by filterdrecv-p3mdw1-85cc49d4fc-pm6p5 with SMTP id filterdrecv-p3mdw1-85cc49d4fc-pm6p5-17-60672EFC-43 2021-04-02 14:49:32.64399326 +0000 UTC m=+850591.020952345 Received: from herokuapp.com (unknown) by ismtpd0170p1iad2.sendgrid.net (SG) with ESMTP id qfhAs8kLS7WN_0bXBGHepg for ; Fri, 02 Apr 2021 14:49:32.526 +0000 (UTC) Date: Fri, 02 Apr 2021 14:49:32 +0000 (UTC) From: marcandre-ruby-core@marc-andre.ca Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 79230 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 17771 X-Redmine-Issue-Author: headius X-Redmine-Sender: marcandre X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?6=2FIMxCQLDposcQf5wmbDAtfaKduBAO0bKyhL3BGZtMQ5q7K2TvpbN6A7JIyt9E?= =?us-ascii?Q?aOXwSsVqjRMAbZvW0ZD2Qqmxe4KLfSU5=2F72Cyj3?= =?us-ascii?Q?4eSmFntjvD+k0I=2FLseyIexk5kXAwGKVbd87urfI?= =?us-ascii?Q?xc82QZcNvzpEHGQu3O0SeJOmi=2F3qdJKZw+zNyeW?= =?us-ascii?Q?RN54m14inV=2FEysrgG0fy3uNOGtebR1f1wLNjyRy?= =?us-ascii?Q?=2FllL11bsJ8+RRv9L4H=2FNB8w60SO9FAg9Z5v+vI?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 103187 Subject: [ruby-core:103187] [Ruby master Feature#17771] String#start_with? should not construct MatchData or set $~ X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17771 has been updated by marcandre (Marc-Andre Lafortune). I also believe it is unintended behavior and should be removed. ---------------------------------------- Feature #17771: String#start_with? should not construct MatchData or set $~ https://bugs.ruby-lang.org/issues/17771#change-91262 * Author: headius (Charles Nutter) * Status: Open * Priority: Normal ---------------------------------------- I am working on making $~ more thread-safe in JRuby and came across this unexpected behavior: ```ruby $ rvm ruby-3.0 do ruby -e '"foo".start_with?(/foo/); p $~' # ``` The `start_with?` method was added 11 years ago in https://bugs.ruby-lang.org/issues/3388 but I do not think the set of $~ was an intended feature. The `start_with?` method could be much faster and more thread-safe if it did not use the frame-local backref slot and did not allocate a MatchData. Compare with `match?` which was added specifically (without MatchData or backref setting) to provide a fast way to check if a Regexp matches. I propose that `start_with?` stop constructing MatchData, stop setting backref, and provide only its boolean result in the same way as `match?`. -- https://bugs.ruby-lang.org/