From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id B2C8D1F4B4 for ; Fri, 2 Apr 2021 04:24:49 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id DB0451209AB; Fri, 2 Apr 2021 13:23:47 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 67EE11209A6 for ; Fri, 2 Apr 2021 13:23:45 +0900 (JST) Received: by filterdrecv-p3mdw1-85cc49d4fc-495tw with SMTP id filterdrecv-p3mdw1-85cc49d4fc-495tw-20-60669C88-C 2021-04-02 04:24:40.3031556 +0000 UTC m=+813104.843270920 Received: from herokuapp.com (unknown) by ismtpd0172p1mdw1.sendgrid.net (SG) with ESMTP id 9ZsFoCkgQKOPLlOvyWztVg for ; Fri, 02 Apr 2021 04:24:40.228 +0000 (UTC) Date: Fri, 02 Apr 2021 04:24:40 +0000 (UTC) From: merch-redmine@jeremyevans.net Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 79207 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 17773 X-Redmine-Issue-Author: sawa X-Redmine-Sender: jeremyevans0 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?RVE3t853K5scBhbmJHUzZTFFeVC=2FZSUmHZ0Dc+26wcEi2CTgsF1oz0wTSSxGGN?= =?us-ascii?Q?BI0e5l35iNRVl5IkGewJ+ZsifwbUjt0EalRVWoc?= =?us-ascii?Q?9VcLf0XI=2Fy6vNQ8M6xYIwvnFyru+FZYR7gzae88?= =?us-ascii?Q?AbIBYiZQIf+KCOuAcXa8lNJa69fyLClaiItWiDf?= =?us-ascii?Q?l=2FFTO5I4ua15Da8eeCJe3+UqGCCJYYDyIFyEqFA?= =?us-ascii?Q?FnvuF48ykB=2FGDFN2Y=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 103164 Subject: [ruby-core:103164] [Ruby master Feature#17773] Alias `Numeric#zero?` and `Float#zero?` as `Numeric#empty?` and `Float#empty?` X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17773 has been updated by jeremyevans0 (Jeremy Evans). I'm against this. `empty?` exists on collection classes, and numbers are not collections, nor sets. Can you provide a reference to a set theoretic definition of the number 0 as the empty set? Even if so, most Ruby programmers are not working in set theory and treating numbers as sets. If you are checking for user input, aliasing `zero?` to `empty?` seems wrong, as `0` is a valid non-empty user input. In general, if you care whether a user input was empty, you should check whether a user input string is empty before converting it to a number, instead of after. ---------------------------------------- Feature #17773: Alias `Numeric#zero?` and `Float#zero?` as `Numeric#empty?` and `Float#empty?` https://bugs.ruby-lang.org/issues/17773#change-91237 * Author: sawa (Tsuyoshi Sawada) * Status: Open * Priority: Normal ---------------------------------------- When dealing with user input fields as in web applications, there are typical values that we want to consider as the default and/or absence of user input. For string/text inputs, list items, and attributes, we have `String#empty?`, `Array#empty?`, and `Hash#empty?` respectively, which seem to correspond to those cases. As for numerics, there are `Numeric#zero?` and `Float#zero?`. However, there is no single term that covers all these cases. In a routine to check through the fields whether there is user input, we have to selectively use `empty?` or `zero?` depending on the type of the input field. Many programming languages other than Ruby typically consider these values as falsy with respect to logical calculation. Ruby handles only `nil` and `false` as falsy, and that has clear advantages in many aspects, but with the cost of losing a simple way to handle these default values. I propose to alias `Numeric#zero?` as `Numeric#empty?` and `Float#zero?` as `Float#empty?` so that we can simply use `empty?`. At first, calling zero as empty might sound strange, but at least for non-negative integers, set theoretic definitions usually define zero as the empty set, so it is not that strange after all. Ruby on Rails' `blank?` is conceptually similar to this, but `0.blank?` returns `false`, so it is a different concept. -- https://bugs.ruby-lang.org/