ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: jean.boussier@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:103134] [Ruby master Bug#17765] Segmentation fault when calling String#gsub
Date: Wed, 31 Mar 2021 22:13:09 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-91207.20210331221308.13804@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-17765.20210331115758.13804@ruby-lang.org

Issue #17765 has been updated by byroot (Jean Boussier).


> But without success so far.

I wouldn't be surprised if the bug wasn't in `gsub` itself, but in some C extension that would generate a faulty string on which `gsub` would trip. I see you have `thrift` loaded for instance. IIRC that's a binary format parser like protobuf etc, it might be creating strings improperly.

This could prove very hard to track. 

----------------------------------------
Bug #17765: Segmentation fault when calling String#gsub
https://bugs.ruby-lang.org/issues/17765#change-91207

* Author: lenwood (Paul Martensen)
* Status: Open
* Priority: Normal
* ruby -v: ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux-musl]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
We recently had a ruby segfault occuring while invoking `String#gsub`. 

The line in the code looks like this:

``` ruby
def sanitize_for_prometheus(string_or_symbol)
  reg = /[^a-zA-Z_0-9]/
  string_or_symbol.to_s.downcase.gsub(reg, '_')
end
```

And we've tried to replicate the segfault (on a different machine) with this script:

```rb
def sanitize_for_prometheus(string_or_symbol)
  reg = /[^a-zA-Z_0-9]/
  string_or_symbol.to_s.downcase.gsub(reg, '_')
end

def rand_string_or_symbol
  @o ||= [('a'..'z').to_a, ('A'..'Z').to_a, (0..9).to_a, '-', '.'].flatten
  str = @o.sample(50).join
  rand > 0.5 ? str.to_sym : str
end

loop { sanitize_for_prometheus rand_string_or_symbol }
```

But without success so far. I have attached a shortened version of the log file for reference.

 


---Files--------------------------------
segfault.log (60.8 KB)
segfault_gsub.rb (343 Bytes)


-- 
https://bugs.ruby-lang.org/

      parent reply	other threads:[~2021-03-31 22:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 11:57 [ruby-core:103127] [Ruby master Bug#17765] Segmentation fault when calling String#gsub paul
2021-03-31 13:10 ` [ruby-core:103128] " mame
2021-03-31 22:13 ` jean.boussier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-91207.20210331221308.13804@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).