From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 8E05A1F4B4 for ; Tue, 26 Jan 2021 01:47:52 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id A9C0D120AC0; Tue, 26 Jan 2021 10:46:57 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 53994120ABE for ; Tue, 26 Jan 2021 10:46:56 +0900 (JST) Received: by filterdrecv-p3mdw1-7cc5db4d68-mcmkv with SMTP id filterdrecv-p3mdw1-7cc5db4d68-mcmkv-20-600F74BF-19 2021-01-26 01:47:43.568970084 +0000 UTC m=+20937.798193133 Received: from herokuapp.com (unknown) by ismtpd0074p1mdw1.sendgrid.net (SG) with ESMTP id 0LahM5x3Sk-AiNRdsZq0Hg for ; Tue, 26 Jan 2021 01:47:43.419 +0000 (UTC) Date: Tue, 26 Jan 2021 01:47:43 +0000 (UTC) From: shugo@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 78158 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17429 X-Redmine-Issue-Author: shugo X-Redmine-Issue-Assignee: matz X-Redmine-Sender: shugo X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?A4qw=2FE7uJv6zjRy5ZA2RlSNSopH4PRxwlkqj2Qg3aeTPAJEyiiKFTOX5HoKmT+?= =?us-ascii?Q?C5iMoOQFW58n+qy8mq318E19Fny1KrR0XeALPZp?= =?us-ascii?Q?E8KmxeIC8AnuR7XH2gzrx=2FXzfYoC4nWGCw+lju1?= =?us-ascii?Q?R5QT68lFrjw2HkNPo4jNnNifdMx3wdHxu3TH39O?= =?us-ascii?Q?huEMNqvvRXcQiRywIXyIl4XHmWn4j2KF6sR=2FeOI?= =?us-ascii?Q?jTuJ0ivQEwc9QADrA=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 102247 Subject: [ruby-core:102247] [Ruby master Bug#17429] Prohibit include/prepend in refinement modules X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17429 has been updated by shugo (Shugo Maeda). Assignee set to matz (Yukihiro Matsumoto) @eregon @marcandre Thanks for your feedback. The remaining issue is the name of the new method. I came up with the following options: 1. Refinement#import 2. Refinement#mix 3. Refinement#include (different behavior from Module#include) @matz Which do you like, or do you have another option in mind? ---------------------------------------- Bug #17429: Prohibit include/prepend in refinement modules https://bugs.ruby-lang.org/issues/17429#change-90095 * Author: shugo (Shugo Maeda) * Status: Open * Priority: Normal * Assignee: matz (Yukihiro Matsumoto) * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- include/prepend in refinement modules has implementation difficulties such as #17007 and #17379, and tends to be misleading like #17374. How about to prohibit it in future versions? Method copy like #17380 may be more convenient, but it's confusing to use names include and prepend because semantics is different from the original ones. -- https://bugs.ruby-lang.org/