From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id E13FD1F4B4 for ; Sun, 24 Jan 2021 09:31:17 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 371A7120946; Sun, 24 Jan 2021 18:30:21 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 8620012092F for ; Sun, 24 Jan 2021 18:30:18 +0900 (JST) Received: by filterdrecv-p3iad2-668897d795-k84kh with SMTP id filterdrecv-p3iad2-668897d795-k84kh-20-600D3E5B-6 2021-01-24 09:31:07.056996363 +0000 UTC m=+383317.587151993 Received: from herokuapp.com (unknown) by ismtpd0036p1mdw1.sendgrid.net (SG) with ESMTP id A9p5jCDRTni99r64TAOk_w for ; Sun, 24 Jan 2021 09:31:06.958 +0000 (UTC) Date: Sun, 24 Jan 2021 09:31:07 +0000 (UTC) From: zverok.offline@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 78133 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 17330 X-Redmine-Issue-Author: zverok X-Redmine-Sender: zverok X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?3be0g8093pjUjT94eiCA64csFDBI=2FmHQTWm54P5gda7=2F0IgAlohZqF3XQ3AAbN?= =?us-ascii?Q?IRDcs3ZPyJiDFOLtQ2VvD5SN4QHZ6TRA1WUuWeQ?= =?us-ascii?Q?d0pzfAtWQISO=2FEOdh=2FXGDie7sv+1slajw=2F1N=2F0Y?= =?us-ascii?Q?3XIAmz=2FsklJCFxdNBhoah=2FO2vj9IGLt95a6im2X?= =?us-ascii?Q?uS8Aoi9we3fDZEEgXcFa2FQW4IzRsNiMqdDmOGr?= =?us-ascii?Q?GiPIyga8sY=2FW50R=2FQ=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 102225 Subject: [ruby-core:102225] [Ruby master Feature#17330] Object#non X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17330 has been updated by zverok (Victor Shepelev). @nobu > This seems readable enough and more flexible. ```ruby return Faraday.get(url).then {_1.body if _1.successful?} ``` I argue that the idiom (return something/continue with something, conditionally) is so frequent, that it should be more atomic. > Or, make `successful?` to return `self` or `nil` That's what I started this ticket with! * This is not natural for Ruby: `nonzero?` is frequently mocked and generally considered a "design error"; Rails' `presence` has kind of the same vibe * This requires me to change Faraday (which, to be clear, I have no relation to), and then go and change every library which causes the same idiom :) * This is solving very particular case (just like `nonzero?` and `presence`), I am talking about generic. Here's one more example: ```ruby Faraday.get(url).body.then { JSON.parse(_1, symbolize_names: true) }.non { _1.key?('error') }&.dig('user', 'status') ``` ---------------------------------------- Feature #17330: Object#non https://bugs.ruby-lang.org/issues/17330#change-90075 * Author: zverok (Victor Shepelev) * Status: Open * Priority: Normal ---------------------------------------- (As always "with core" method proposals, I don't expect quick success, but hope for a fruitful discussion) ### Reasons: Ruby always tried to be very chainability-friendly. Recently, with introduction of `.then` and `=>`, even more so. But one pattern that frequently emerges and doesn't have good idiomatic expression: calculate something, and if it is not a "good" value, return `nil` (or provide default value with `||`). There are currently two partial solutions: 1. `nonzero?` in Ruby core (frequently mocked for "inadequate" behavior, as it is looking like predicate method, but instead of `true`/`false` returns an original value or `nil`) 2. ActiveSupport `Object#presence`, which also returns an original value or `nil` if it is not "present" (e.g. `nil` or `empty?` in AS-speak) Both of them prove themselves quite useful in some domains, but they are targeting only those particular domains, look unlike each other, and can be confusing. ### Proposal: Method `Object#non` (or `Kernel#non`), which receives a block, calls it with receiver and returns `nil` (if block matched) or receiver otherwise. ##### Prototype implementation: ```ruby class Object def non self unless yield(self) end end ``` ##### Usage examples: 1. With number: ```ruby limit = calculate.some.limit limit.zero? ? DEFAULT_LIMIT : limit # or, with nonzero? calculate.some.limit.nonzero? || DEFAULT_LIMIT # with non: calculate.some.limit.non(&:zero?) || DEFAULT_LIMIT # ^ Note here, how, unlike `nonzero?`, we see predicate-y ?, but it is INSIDE the `non()` and less confusing ``` 2. With string: ```ruby name = params[:name] if params[:name] && !params[:name].empty? # or, with ActiveSupport: name = params[:name].presence # with non: name = params[:name]&.non(&:empty?) ``` 3. More complicated example ```ruby action = payload.dig('action', 'type') return if PROHIBITED_ACTIONS.include?(action) send("do_#{action}") # with non & then: payload.dig('action', 'type') .non { |action| PROHIBITED_ACTIONS.include?(action) } &.then { |action| send("do_#{action}") } ``` ### Possible extensions of the idea It is quite tempting to define the symmetric method named -- as we already have `Object#then` -- `Object#when`: ```ruby some.long.calculation.when { |val| val < 10 } # returns nil if value >= 10 # or even... with support for === some.long.calculation.when(..10)&.then { continue to do something } ``` ...but I am afraid I've overstayed my welcome :) -- https://bugs.ruby-lang.org/