[ruby-core:101710] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[ruby-core:101710] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[hsbt]

Issue #17473 has been reported by hsbt (Hiroshi SHIBATA).

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:101711] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[eregontp]

Issue #17473 has been updated by Eregon (Benoit Daloze).


If we do so, could we actually define most of Pathname in Ruby, and not in C?

Right now, https://github.com/ruby/ruby/blob/3fc53de5c961cc8fa2b6acbd63874b89fe709520/ext/pathname/pathname.c is essentially just a bunch of rb_funcall() calls, which are no faster than Ruby code, but makes it harder to reuse on other implementations, and less readable and harder to maintain.

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89534

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:101738] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[mame]

Issue #17473 has been updated by mame (Yusuke Endoh).

Assignee set to akr (Akira Tanaka)

The proposal lacks one background, so I'd like to add it. Rubygems cannot allow uesrs to choose the version of a gem that rubygems itself are using. So, we want to make Rubygems independent with any gems. According to @hsbt, Rubygems is using Pathname, FileUtils, Tsort, etc. Though FileUtils and Tsort are relatively easy to be removed from the dependencies, Pathname looks difficult.

In addition, of course, Pathname is widely used, and the API of Pathname looks stable. So I also think it deserves built-in.

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89560

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:101748] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[eregontp]

Issue #17473 has been updated by Eregon (Benoit Daloze).


I forgot to mention, +1 from me for Pathname in core, if it's written mostly in Ruby.

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89570

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:101756] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[daniel]

Issue #17473 has been updated by Dan0042 (Daniel DeLorme).


mame (Yusuke Endoh) wrote in #note-2:
> Though FileUtils and Tsort are relatively easy to be removed from the dependencies, Pathname looks difficult.

Isn't Pathname dependent on FileUtils though?

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89583

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:101762] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[mame]

Issue #17473 has been updated by mame (Yusuke Endoh).


Dan0042 (Daniel DeLorme) wrote in #note-4:
> Isn't Pathname dependent on FileUtils though?

Yes. It uses only `FileUtils.mkpath` and `rm_r`. Rubygems also uses them, so @hsbt is preparing to propose making a very limited set of FileUtils methods built-in, too.

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89588

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:101778] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[eregontp]

Issue #17473 has been updated by Eregon (Benoit Daloze).


I thought about FileUtils too, but it's required lazily for these two methods.
So I think it might be fine to move only Pathname to core, and accept that `Pathname#{mkpath,rmtree}` `require`s `fileutils` when used.

I think having part of FileUtils defined in core would be confusing.

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89606

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:101813] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[shyouhei]

Issue #17473 has been updated by shyouhei (Shyouhei Urabe).


JFYI pathname was born as a pure-ruby library, then was eventually translated into C (in commit:4bf3cb5ba9c0242bd5a6d0d55b7db9f837c09edf).  Don't know the reason behind that move though.  @akr do you remember?

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89640

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:101814] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[eregontp]

Issue #17473 has been updated by Eregon (Benoit Daloze).


shyouhei (Shyouhei Urabe) wrote in #note-7:
> JFYI pathname was born as a pure-ruby library, then was eventually translated into C (in commit:4bf3cb5ba9c0242bd5a6d0d55b7db9f837c09edf).  Don't know the reason behind that move though.  @akr do you remember?

I know, I'd like to undo that change (I can make a PR), except for the parts which are significantly faster in C (I think only `Pathname#<=>` / `path_cmp`).
Then, we could share more of Pathname between Ruby implementations, and avoid maintaining both a Ruby and C version.
There is a copy in [TruffleRuby](https://github.com/oracle/truffleruby/blob/5ab35083f1cebd44b05ad5e8706196118184c328/lib/truffle/pathname.rb), in JRuby and in Rubinius right now due to that commit :/
@akr Would that be OK?

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89641

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:101826] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[hsbt]

Issue #17473 has been updated by hsbt (Hiroshi SHIBATA).


>Then, we could share more of Pathname between Ruby implementations, and avoid maintaining both a Ruby and C version.

I'm not sure how embedded pure-Ruby implementation to core classes. The above request is the different request.

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89652

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:101835] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[duerst]

Issue #17473 has been updated by duerst (Martin Dürst).


hsbt (Hiroshi SHIBATA) wrote in #note-9:

> I'm not sure how embedded pure-Ruby implementation to core classes. The above request is the different request.

I support making Pathname part of core Ruby. It's an extremely convenient library that I use very often.

Just for the record, String#unicode_normalize is part of a core class but is implemented in pure Ruby. It's a single case, and includes loading code on demand. If we do more pure-Ruby implementations for core classes, we should think again about the best way to do it. 

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89665

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

[ruby-core:101848] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[eregontp]

Issue #17473 has been updated by Eregon (Benoit Daloze).


hsbt (Hiroshi SHIBATA) wrote in #note-9:
> I'm not sure how embedded pure-Ruby implementation to core classes. The above request is the different request.

It's also related, if the decision was to move all of Pathname to C (due to some reason of moving it to core), I would be strongly against it.
I think concretely we can just have `pathname.rb` at the root, similar to e.g. `dir.rb`.

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89681

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:102012] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[akr]

Issue #17473 has been updated by akr (Akira Tanaka).


shyouhei (Shyouhei Urabe) wrote in #note-7:
> JFYI pathname was born as a pure-ruby library, then was eventually translated into C (in commit:4bf3cb5ba9c0242bd5a6d0d55b7db9f837c09edf).  Don't know the reason behind that move though.  @akr do you remember?

I had a plan that Pathname contains a FD optionally as root directory and 
use openat() and other *at system call.
No progress after translation to C, though


----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-89860

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:106989] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[Eregon (Benoit Daloze)]

Issue #17473 has been updated by Eregon (Benoit Daloze).


I plan to make a PR to move Pathname back to Ruby for all methods which don't significantly gain from being written in C.
I'm coming from https://github.com/oracle/truffleruby/issues/2559, which is additional motivation for it, the current situation hurts compatibility between Ruby impls for seemingly no gain.

We can still decide to keep pathname as stdlib or move it to core either way (there is already `ext/pathname/lib/pathname.rb` anyway, it'd just become bigger and `ext/pathname/pathname.c` smaller).

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-95820

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:106990] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[Eregon (Benoit Daloze)]

Issue #17473 has been updated by Eregon (Benoit Daloze).


Regarding openat(), [4bf3cb5ba9c0242bd5a6d0d55b7db9f837c09edf](https://bugs.ruby-lang.org/projects/ruby-master/repository/git/revisions/4bf3cb5ba9c0242bd5a6d0d55b7db9f837c09edf) was 11 years ago, so I assume there is little demand or need.
It's easy enough to just use absolute paths before `chdir` (or avoid using them after chdir) or keep the old CWD as a Pathname instance, and of course some platforms don't have `openat()`.

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-95821

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/

[ruby-core:106999] [Ruby master Feature#17473] Make Pathname to embedded class of Ruby

[deivid]

Issue #17473 has been updated by deivid (David Rodríguez).


For what it's worth, although for unrelated reasons, I completely rewrote `Pathname` in pure Ruby here: https://github.com/rubygems/rubygems/pull/4992.

----------------------------------------
Feature #17473: Make Pathname to embedded class of Ruby
https://bugs.ruby-lang.org/issues/17473#change-95829

* Author: hsbt (Hiroshi SHIBATA)
* Status: Open
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it.

Any thought?



-- 
https://bugs.ruby-lang.org/