From: marcandre-ruby-core@marc-andre.ca
To: ruby-core@ruby-lang.org
Subject: [ruby-core:101942] [Ruby master Bug#17512] ostruct super regression
Date: Wed, 06 Jan 2021 00:43:10 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-89789.20210106004310.48311@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-17512.20210105202427.48311@ruby-lang.org
Issue #17512 has been updated by marcandre (Marc-Andre Lafortune).
Status changed from Assigned to Closed
Fixed and released as 0.3.2, thanks!
----------------------------------------
Bug #17512: ostruct super regression
https://bugs.ruby-lang.org/issues/17512#change-89789
* Author: HParker (Adam Hess)
* Status: Closed
* Priority: Normal
* Assignee: marcandre (Marc-Andre Lafortune)
* ruby -v: 3.0.0
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
In ruby 3.0, Calling super on ostruct always returns nil. This is a regression in ruby 3.0 introduced when fixing another issue.
introduced by:
- https://bugs.ruby-lang.org/issues/12136
- https://github.com/ruby/ruby/commit/e026e186f4a01aa3f6cd02ae6ef33f44f129361c
This unintentionally changed `super` behavior in classes that inherit from OpenStruct.
```ruby
require 'ostruct'
class Foo < OpenStruct
def foo
super
end
end
p Foo.new(foo: 123).foo
```
```
Ruby 3.0:
=> nil
Ruby 2.7:
=> 123
```
Potential fix is to bring back some of the behavior reverted in issue #12136 to allow method missing to sometimes respond to methods with zero arguments.
This is implemented in: https://github.com/ruby/ruby/pull/4028 and included as a patch attached to this issue.
---Files--------------------------------
0001-Allow-ostruct-to-return-a-value-on-super.patch (1.7 KB)
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2021-01-06 0:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 20:24 [ruby-core:101939] [Ruby master Bug#17512] ostruct super regression adamhess1991
2021-01-05 23:05 ` [ruby-core:101941] " hsbt
2021-01-06 0:43 ` marcandre-ruby-core [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-89789.20210106004310.48311@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).