[ruby-core:101913] [Ruby master Bug#17510] enable constant cache on Ractors

[ruby-core:101913] [Ruby master Bug#17510] enable constant cache on Ractors

[ko1]

Issue #17510 has been reported by ko1 (Koichi Sasada).

----------------------------------------
Bug #17510: enable constant cache on Ractors
https://bugs.ruby-lang.org/issues/17510

* Author: ko1 (Koichi Sasada)
* Status: Open
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
constant cache `IC` is accessed by non-atomic manner and there are
thread-safety issues, so Ruby 3.0 disables to use const cache on
non-main ractors.

To enable the constant cache, we need to make `IC` access atomically,
and this is a patch: https://github.com/ruby/ruby/pull/4022

This patch enables it by introducing imemo_constcache and allocates
it by every re-fill of const cache like imemo_callcache.

Benchmark:

```ruby
Warning[:experimental] = false

def tarai(x, y, z) = Object && # useless constant reference
  x <= y ? y : tarai(tarai(x-1, y, z),
                     tarai(y-1, z, x),
                     tarai(z-1, x, y))
def task = tarai(12, 6, 0)
#
require 'benchmark'

Benchmark.bm{|x|
  x.report('seq'){ 4.times{ task } }
  x.report('par'){ 4.times.map{ Ractor.new{ task } }.each(&:take) }
}
```

```
master (095972e799):
       user     system      total        real
seq  1.618664   0.001916   1.620580 (  1.620620)
par 18.168252  16.840400  35.008652 (  9.452195)

This patch:
       user     system      total        real
seq  1.587542   0.000000   1.587542 (  1.587548)
par  1.950062   0.000000   1.950062 (  0.497173)
```




-- 
https://bugs.ruby-lang.org/

[ruby-core:101915] [Ruby master Bug#17510] enable constant cache on Ractors

[ko1]

Issue #17510 has been updated by ko1 (Koichi Sasada).

Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN to 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: REQUIRED

this patch is for performance, but it seems be valuable to backport to 3.0.1.

----------------------------------------
Bug #17510: enable constant cache on Ractors
https://bugs.ruby-lang.org/issues/17510#change-89759

* Author: ko1 (Koichi Sasada)
* Status: Closed
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: REQUIRED
----------------------------------------
constant cache `IC` is accessed by non-atomic manner and there are
thread-safety issues, so Ruby 3.0 disables to use const cache on
non-main ractors.

To enable the constant cache, we need to make `IC` access atomically,
and this is a patch: https://github.com/ruby/ruby/pull/4022

This patch enables it by introducing imemo_constcache and allocates
it by every re-fill of const cache like imemo_callcache.

Benchmark:

```ruby
Warning[:experimental] = false

def tarai(x, y, z) = Object && # useless constant reference
  x <= y ? y : tarai(tarai(x-1, y, z),
                     tarai(y-1, z, x),
                     tarai(z-1, x, y))
def task = tarai(12, 6, 0)
#
require 'benchmark'

Benchmark.bm{|x|
  x.report('seq'){ 4.times{ task } }
  x.report('par'){ 4.times.map{ Ractor.new{ task } }.each(&:take) }
}
```

```
master (095972e799):
       user     system      total        real
seq  1.618664   0.001916   1.620580 (  1.620620)
par 18.168252  16.840400  35.008652 (  9.452195)

This patch:
       user     system      total        real
seq  1.587542   0.000000   1.587542 (  1.587548)
par  1.950062   0.000000   1.950062 (  0.497173)
```




-- 
https://bugs.ruby-lang.org/

[ruby-core:101916] [Ruby master Bug#17510] enable constant cache on Ractors

[takashikkbn]

Issue #17510 has been updated by k0kubun (Takashi Kokubun).


commit:e7fc353f04 broke MJIT, so if it's to be backported to 3.0.1, please make sure (commit:87c546b5fa to avoid a conflict and) commit:7a3322a0fd is backported as well.

----------------------------------------
Bug #17510: enable constant cache on Ractors
https://bugs.ruby-lang.org/issues/17510#change-89760

* Author: ko1 (Koichi Sasada)
* Status: Closed
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: REQUIRED
----------------------------------------
constant cache `IC` is accessed by non-atomic manner and there are
thread-safety issues, so Ruby 3.0 disables to use const cache on
non-main ractors.

To enable the constant cache, we need to make `IC` access atomically,
and this is a patch: https://github.com/ruby/ruby/pull/4022

This patch enables it by introducing imemo_constcache and allocates
it by every re-fill of const cache like imemo_callcache.

Benchmark:

```ruby
Warning[:experimental] = false

def tarai(x, y, z) = Object && # useless constant reference
  x <= y ? y : tarai(tarai(x-1, y, z),
                     tarai(y-1, z, x),
                     tarai(z-1, x, y))
def task = tarai(12, 6, 0)
#
require 'benchmark'

Benchmark.bm{|x|
  x.report('seq'){ 4.times{ task } }
  x.report('par'){ 4.times.map{ Ractor.new{ task } }.each(&:take) }
}
```

```
master (095972e799):
       user     system      total        real
seq  1.618664   0.001916   1.620580 (  1.620620)
par 18.168252  16.840400  35.008652 (  9.452195)

This patch:
       user     system      total        real
seq  1.587542   0.000000   1.587542 (  1.587548)
par  1.950062   0.000000   1.950062 (  0.497173)
```




-- 
https://bugs.ruby-lang.org/

[ruby-core:102345] [Ruby master Bug#17510] enable constant cache on Ractors

[naruse]

Issue #17510 has been updated by naruse (Yui NARUSE).

Backport changed from 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONTNEED, 3.0: REQUIRED to 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONTNEED, 3.0: DONE

ruby_3_0 b93e16dc0f45069d4a5fcce20d5c4437e151f0a8.

----------------------------------------
Bug #17510: enable constant cache on Ractors
https://bugs.ruby-lang.org/issues/17510#change-90205

* Author: ko1 (Koichi Sasada)
* Status: Closed
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Backport: 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONTNEED, 3.0: DONE
----------------------------------------
constant cache `IC` is accessed by non-atomic manner and there are
thread-safety issues, so Ruby 3.0 disables to use const cache on
non-main ractors.

To enable the constant cache, we need to make `IC` access atomically,
and this is a patch: https://github.com/ruby/ruby/pull/4022

This patch enables it by introducing imemo_constcache and allocates
it by every re-fill of const cache like imemo_callcache.

Benchmark:

```ruby
Warning[:experimental] = false

def tarai(x, y, z) = Object && # useless constant reference
  x <= y ? y : tarai(tarai(x-1, y, z),
                     tarai(y-1, z, x),
                     tarai(z-1, x, y))
def task = tarai(12, 6, 0)
#
require 'benchmark'

Benchmark.bm{|x|
  x.report('seq'){ 4.times{ task } }
  x.report('par'){ 4.times.map{ Ractor.new{ task } }.each(&:take) }
}
```

```
master (095972e799):
       user     system      total        real
seq  1.618664   0.001916   1.620580 (  1.620620)
par 18.168252  16.840400  35.008652 (  9.452195)

This patch:
       user     system      total        real
seq  1.587542   0.000000   1.587542 (  1.587548)
par  1.950062   0.000000   1.950062 (  0.497173)
```




-- 
https://bugs.ruby-lang.org/