From: ko1@atdot.net
To: ruby-core@ruby-lang.org
Subject: [ruby-core:101915] [Ruby master Bug#17510] enable constant cache on Ractors
Date: Mon, 04 Jan 2021 19:09:20 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-89759.20210104190919.17@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-17510.20210104164725.17@ruby-lang.org
Issue #17510 has been updated by ko1 (Koichi Sasada).
Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN to 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: REQUIRED
this patch is for performance, but it seems be valuable to backport to 3.0.1.
----------------------------------------
Bug #17510: enable constant cache on Ractors
https://bugs.ruby-lang.org/issues/17510#change-89759
* Author: ko1 (Koichi Sasada)
* Status: Closed
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: REQUIRED
----------------------------------------
constant cache `IC` is accessed by non-atomic manner and there are
thread-safety issues, so Ruby 3.0 disables to use const cache on
non-main ractors.
To enable the constant cache, we need to make `IC` access atomically,
and this is a patch: https://github.com/ruby/ruby/pull/4022
This patch enables it by introducing imemo_constcache and allocates
it by every re-fill of const cache like imemo_callcache.
Benchmark:
```ruby
Warning[:experimental] = false
def tarai(x, y, z) = Object && # useless constant reference
x <= y ? y : tarai(tarai(x-1, y, z),
tarai(y-1, z, x),
tarai(z-1, x, y))
def task = tarai(12, 6, 0)
#
require 'benchmark'
Benchmark.bm{|x|
x.report('seq'){ 4.times{ task } }
x.report('par'){ 4.times.map{ Ractor.new{ task } }.each(&:take) }
}
```
```
master (095972e799):
user system total real
seq 1.618664 0.001916 1.620580 ( 1.620620)
par 18.168252 16.840400 35.008652 ( 9.452195)
This patch:
user system total real
seq 1.587542 0.000000 1.587542 ( 1.587548)
par 1.950062 0.000000 1.950062 ( 0.497173)
```
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2021-01-04 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 16:47 [ruby-core:101913] [Ruby master Bug#17510] enable constant cache on Ractors ko1
2021-01-04 19:09 ` ko1 [this message]
2021-01-04 21:14 ` [ruby-core:101916] " takashikkbn
2021-02-01 9:23 ` [ruby-core:102345] " naruse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-89759.20210104190919.17@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).