From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 2E8351F4B4 for ; Sat, 2 Jan 2021 12:50:59 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 05111120A43; Sat, 2 Jan 2021 21:50:07 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id C21A6120992 for ; Sat, 2 Jan 2021 21:50:04 +0900 (JST) Received: by filterdrecv-p3mdw1-7474cd8bfd-ntdvf with SMTP id filterdrecv-p3mdw1-7474cd8bfd-ntdvf-19-5FF06C2A-14 2021-01-02 12:50:50.519985509 +0000 UTC m=+1950512.537246725 Received: from herokuapp.com (unknown) by ismtpd0017p1iad2.sendgrid.net (SG) with ESMTP id mhMbcJR9R4-Z4Eb2xLMzUQ for ; Sat, 02 Jan 2021 12:50:50.444 +0000 (UTC) Date: Sat, 02 Jan 2021 12:50:50 +0000 (UTC) From: eregontp@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 77785 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 17490 X-Redmine-Issue-Author: k0kubun X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?KippOI8ZHtTweq7XfQzW93937kJ4QNWwSBuHnaMEcr0fPdvEFFp=2Ff7Nnb=2Fy0lz?= =?us-ascii?Q?pF6LZJnPloYmGR5U+ramB1FkCP=2Fd+Q8azRkOO3T?= =?us-ascii?Q?UDZgUZIPkxTq9sT1MpKCcwVS499ciXUFeh6rZsr?= =?us-ascii?Q?0uP5V82avsjVIBuzG5OSSCNhMN7YpteNEVl0Fww?= =?us-ascii?Q?zqN8+EtdVbzTKTYky0eUp3E0ddrWovBn957ivub?= =?us-ascii?Q?qEMlHeRUdr5CdCjgY=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 101879 Subject: [ruby-core:101879] [Ruby master Feature#17490] Rename RubyVM::MJIT to RubyVM::JIT X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17490 has been updated by Eregon (Benoit Daloze). > ## Release notes > > Actually I think MJIT is a lot clearer than JIT in e.g. https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ > MJIT is not the only "Ruby Just-in-Time compiler", so being precise seems helpful to me when mentioning it by name. > > Are you saying, if we write "JIT" in an MRI release note, readers might get confused about whether it's MRI's JIT or TruffleRuby's Graal? Not really, I'm saying the "JIT" is just unclear, "which JIT is it?". The 3.0.0 release notes are hard to read for me because they mix MJIT and JIT. If we use MJIT everywhere in that note, then I think it is very clear. If we use JIT everywhere in that note, then I think it is very unclear. I show examples below. > Once we have another tier of JIT in MRI, I'd agree it's useful to mention the name "MJIT" at least in a NEWS like: Yes, I was also thinking about that, if there is another JIT in MRI then `RubyVM::JIT` would become ambiguous. > but a release note is something which is read by many non-Rubyist people who often don't know there has been a JIT since Ruby 2.6 in the first place. That means they didn't read previous release notes then? So probably they read the 3.0 notes because of the new major version. I think a single sentence, or a link for MJIT would be best, e.g., "MJIT is a method JIT for CRuby available since Ruby 2.6." > Many people thought Ruby 3 newly introduced a JIT, reading the latest release note. I think that's partly caused by using the term JIT and not MJIT in some places. "Many improvements were implemented in MJIT." is very clear. "As of Ruby 3.0, JIT is supposed to give performance improvements in limited workloads" is unclear, does it mean a JIT appeared in 3.0? (no) Same with JIT->MJIT is clear: "As of Ruby 3.0, MJIT is supposed to give performance improvements in limited workloads" ---------------------------------------- Feature #17490: Rename RubyVM::MJIT to RubyVM::JIT https://bugs.ruby-lang.org/issues/17490#change-89720 * Author: k0kubun (Takashi Kokubun) * Status: Open * Priority: Normal ---------------------------------------- ## Background In my understanding, MJIT is a codename like YARV which many people outside Ruby community are not familiar with, so I've used JIT in NEWS or release notes to avoid explaining the "M" part whenever we release a new version. However, because we have the name "MJIT" in one of our constants, we've had some naming inconsistency. For instance, --jit is not --mjit and it's not consistent. ## Proposal Have the same constant as `RubyVM::JIT`, deprecate `RubyVM::MJIT` from Ruby 3.1, and remove the old one in Ruby 3.2. ## Impact This impacts only [Feature #14830] `RubyVM::MJIT.pause` / `RubyVM::MJIT.resume`, which is basically for k0kubun's own testing. -- https://bugs.ruby-lang.org/