From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id E98491F4B4 for ; Mon, 28 Dec 2020 11:53:24 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 2331A120A88; Mon, 28 Dec 2020 20:52:36 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 7903C120A6C for ; Mon, 28 Dec 2020 20:52:33 +0900 (JST) Received: by filterdrecv-p3mdw1-7474cd8bfd-ntdvf with SMTP id filterdrecv-p3mdw1-7474cd8bfd-ntdvf-19-5FE9C72A-5 2020-12-28 11:53:14.073075095 +0000 UTC m=+1515056.090336229 Received: from herokuapp.com (unknown) by ismtpd0102p1mdw1.sendgrid.net (SG) with ESMTP id oVXoaix_S1ucOnHGVSfxpQ for ; Mon, 28 Dec 2020 11:53:14.007 +0000 (UTC) Date: Mon, 28 Dec 2020 11:53:14 +0000 (UTC) From: eregontp@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 77676 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 17472 X-Redmine-Issue-Author: naruse X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?KippOI8ZHtTweq7XfQzW93937kJ4QNWwSBuHnaMEcr2BJ83ipzMPUeDWvDQBgj?= =?us-ascii?Q?boHb7IdQjrWGNlk+zax4ssnjJIEOVnUpSUC=2FsxZ?= =?us-ascii?Q?VEfYJ6XYXcGU4Ki5WpPlc0+k8XAqfG8sMNrAo4s?= =?us-ascii?Q?LVogEhdeiZAKiNYuq6l3F1jSEa3CKdlHsmjv=2Fn0?= =?us-ascii?Q?pB1RW3TwYh2kdJss9L8WrUdYnis4ywiwEpW1Vru?= =?us-ascii?Q?NrPaAHQMi8OMs9G8Q=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 101774 Subject: [ruby-core:101774] [Ruby master Feature#17472] HashWithIndifferentAccess like Hash extension X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17472 has been updated by Eregon (Benoit Daloze). naruse (Yui NARUSE) wrote in #note-11: > I think it will not fast. Before we start considering performance trade-offs, do we even have a benchmark where time spent in HashWithIndifferentAccess is significant for a Rails app? ---------------------------------------- Feature #17472: HashWithIndifferentAccess like Hash extension https://bugs.ruby-lang.org/issues/17472#change-89602 * Author: naruse (Yui NARUSE) * Status: Open * Priority: Normal * Target version: 3.1 ---------------------------------------- Rails has [ActiveSupport::HashWithIndifferentAccess](https://api.rubyonrails.org/classes/ActiveSupport/HashWithIndifferentAccess.html), which is widely used in Rails to handle Request, Session, ActionView's form construction, ActiveRecord's DB communication, and so on. It receives String or Symbol and normalize them to fetch the value. But it is implemented with Ruby. If we provide C implementation of that, Rails will gain the performance improvement. summary of previous discussion: https://github.com/rails/rails/pull/40182#issuecomment-687607812 -- https://bugs.ruby-lang.org/