From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 1C2EE1F4B4 for ; Mon, 28 Dec 2020 08:44:06 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 3D04C120A46; Mon, 28 Dec 2020 17:43:13 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 0E8B7120A43 for ; Mon, 28 Dec 2020 17:43:10 +0900 (JST) Received: by filterdrecv-p3las1-685fdc5bbc-5nmxj with SMTP id filterdrecv-p3las1-685fdc5bbc-5nmxj-18-5FE99AC7-1 2020-12-28 08:43:51.116730638 +0000 UTC m=+1503696.910113263 Received: from herokuapp.com (unknown) by geopod-ismtpd-4-4 (SG) with ESMTP id sySAFxJDT02MuUbUFrl0Yg for ; Mon, 28 Dec 2020 08:43:50.951 +0000 (UTC) Date: Mon, 28 Dec 2020 08:43:51 +0000 (UTC) From: duerst@it.aoyama.ac.jp Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 77672 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17420 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: ko1 X-Redmine-Sender: duerst X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?uQY=2F2xNrNfHHTWbKn6MBvvzfU5Pqk9I4lnOVb0CFDuv=2FXt0jMpizt6scsFcU+j?= =?us-ascii?Q?E4ntuUAUo=2FzBLw2hv5vbyiM0iDlfwSwZAkwVdQ6?= =?us-ascii?Q?06jfCORcfzr9Q0A3yGcKWG6Marh2I+XHQBBNhHb?= =?us-ascii?Q?G=2F=2FHTMMQwBYmriGhrtYdmH7wKmSKZsoZRBz1h=2FP?= =?us-ascii?Q?YYXtF=2FYQb=2FeosYGTyOGNRrS6wV=2Fcus1iul4uqRP?= =?us-ascii?Q?Ke86ahGQyhpkrAKXU=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 101770 Subject: [ruby-core:101770] [Ruby master Bug#17420] Unsafe mutation of $" when doing non-RubyGems require in Ractor X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17420 has been updated by duerst (Martin D=FCrst). I agree that it would be best to make require work everywhere, but always b= e executed in the main Reactor. That would just be part of the semantics of= require (comment moved from #17477). ---------------------------------------- Bug #17420: Unsafe mutation of $" when doing non-RubyGems require in Ractor https://bugs.ruby-lang.org/issues/17420#change-89598 * Author: Eregon (Benoit Daloze) * Status: Open * Priority: Normal * Assignee: ko1 (Koichi Sasada) * ruby -v: ruby 3.0.0dev (2020-12-16T10:12:48Z master a9a7f4d8b8) [x86_64-l= inux] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- With an empty file `a.rb`: ``` $ ruby --disable-gems -e 'Ractor.new { puts $" }.take' -e:1:in `block in
': can not access global variables $" from non-main= Ractors (RuntimeError) ``` That is expected, given the rules for global variables. ``` ruby --disable-gems -e 'Ractor.new { require "./a.rb"; }.take; p $"' [... , "/home/eregon/a.rb"] ``` Is it OK that the Ractor can do `require`, which does modify `$"`? I think it's not, and it might lead to segfaults if e.g. the main Ractor mu= tates `$"` in parallel to some other Ractor doing `require`. Probably `require` needs to be forbidden in non-main Ractors (it does mutat= e `$"`, so it's logical), or there needs to be always VM-global synchroniza= tion on any access to `$"` (otherwise, segfaults are possible). The latter doesn't seem reasonable, especially when considering the user mi= ght do `$".each { ... }`. --- Note that RubyGems' `require` does not work on non-main Ractors (pretty muc= h expected given it depends on a lot of global state): ``` $ ruby -e 'Ractor.new { require "./a.rb"; }.take' :37:in `require': can not access non-shareable objects in= constant Kernel::RUBYGEMS_ACTIVATION_MONITOR by non-main ractor. (NameErro= r) ``` This probably also has consequences for `autoload`. Maybe the `zeitwerk` gem can help with the mode to resolve all autoload at = once. -- = https://bugs.ruby-lang.org/ Unsubscribe: