ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:100428] [Ruby master Feature#17266] Bundle TypeProf
@ 2020-10-19 14:55 mame
  2020-10-19 22:04 ` [ruby-core:100432] " matz
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: mame @ 2020-10-19 14:55 UTC (permalink / raw)
  To: ruby-core

Issue #17266 has been reported by mame (Yusuke Endoh).

----------------------------------------
Feature #17266: Bundle TypeProf
https://bugs.ruby-lang.org/issues/17266

* Author: mame (Yusuke Endoh)
* Status: Open
* Priority: Normal
----------------------------------------
I'm working on bundling [TypeProf](https://github.com/ruby/typeprof), a type analyzer for non-annotated Ruby code, with Ruby 3.0.  The following PR bundles TypeProf as a bundled gem.

https://github.com/ruby/ruby/pull/3668

Matz was very positive to bundle it with Ruby 3.0, but just for case, I'd like to get approval from matz in a public ticket. I hope we can bundle it in 3.0 preview 2.

For TypeProf, please see my talk at RubyKaigi Takeout 2020:

* https://rubykaigi.org/2020-takeout/presentations/mametter.html
* https://www.youtube.com/watch?v=6KcFdQWp8W0



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:100432] [Ruby master Feature#17266] Bundle TypeProf
  2020-10-19 14:55 [ruby-core:100428] [Ruby master Feature#17266] Bundle TypeProf mame
@ 2020-10-19 22:04 ` matz
  2020-10-27 11:25 ` [ruby-core:100598] " hsbt
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: matz @ 2020-10-19 22:04 UTC (permalink / raw)
  To: ruby-core

Issue #17266 has been updated by matz (Yukihiro Matsumoto).


Approved.

Matz.


----------------------------------------
Feature #17266: Bundle TypeProf
https://bugs.ruby-lang.org/issues/17266#change-88050

* Author: mame (Yusuke Endoh)
* Status: Open
* Priority: Normal
----------------------------------------
I'm working on bundling [TypeProf](https://github.com/ruby/typeprof), a type analyzer for non-annotated Ruby code, with Ruby 3.0.  The following PR bundles TypeProf as a bundled gem.

https://github.com/ruby/ruby/pull/3668

Matz was very positive to bundle it with Ruby 3.0, but just for case, I'd like to get approval from matz in a public ticket. I hope we can bundle it in 3.0 preview 2.

For TypeProf, please see my talk at RubyKaigi Takeout 2020:

* https://rubykaigi.org/2020-takeout/presentations/mametter.html
* https://www.youtube.com/watch?v=6KcFdQWp8W0



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:100598] [Ruby master Feature#17266] Bundle TypeProf
  2020-10-19 14:55 [ruby-core:100428] [Ruby master Feature#17266] Bundle TypeProf mame
  2020-10-19 22:04 ` [ruby-core:100432] " matz
@ 2020-10-27 11:25 ` hsbt
  2020-10-27 14:10 ` [ruby-core:100605] " mame
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: hsbt @ 2020-10-27 11:25 UTC (permalink / raw)
  To: ruby-core

Issue #17266 has been updated by hsbt (Hiroshi SHIBATA).

Assignee set to mame (Yusuke Endoh)
Status changed from Open to Closed

Applied at commit:c05e41035c01ab38bdb279601a08e17921bcdc8e

----------------------------------------
Feature #17266: Bundle TypeProf
https://bugs.ruby-lang.org/issues/17266#change-88228

* Author: mame (Yusuke Endoh)
* Status: Closed
* Priority: Normal
* Assignee: mame (Yusuke Endoh)
----------------------------------------
I'm working on bundling [TypeProf](https://github.com/ruby/typeprof), a type analyzer for non-annotated Ruby code, with Ruby 3.0.  The following PR bundles TypeProf as a bundled gem.

https://github.com/ruby/ruby/pull/3668

Matz was very positive to bundle it with Ruby 3.0, but just for case, I'd like to get approval from matz in a public ticket. I hope we can bundle it in 3.0 preview 2.

For TypeProf, please see my talk at RubyKaigi Takeout 2020:

* https://rubykaigi.org/2020-takeout/presentations/mametter.html
* https://www.youtube.com/watch?v=6KcFdQWp8W0



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:100605] [Ruby master Feature#17266] Bundle TypeProf
  2020-10-19 14:55 [ruby-core:100428] [Ruby master Feature#17266] Bundle TypeProf mame
  2020-10-19 22:04 ` [ruby-core:100432] " matz
  2020-10-27 11:25 ` [ruby-core:100598] " hsbt
@ 2020-10-27 14:10 ` mame
  2020-10-27 18:08 ` [ruby-core:100609] " eregontp
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: mame @ 2020-10-27 14:10 UTC (permalink / raw)
  To: ruby-core

Issue #17266 has been updated by mame (Yusuke Endoh).


Yes, thanks!

----------------------------------------
Feature #17266: Bundle TypeProf
https://bugs.ruby-lang.org/issues/17266#change-88236

* Author: mame (Yusuke Endoh)
* Status: Closed
* Priority: Normal
* Assignee: mame (Yusuke Endoh)
----------------------------------------
I'm working on bundling [TypeProf](https://github.com/ruby/typeprof), a type analyzer for non-annotated Ruby code, with Ruby 3.0.  The following PR bundles TypeProf as a bundled gem.

https://github.com/ruby/ruby/pull/3668

Matz was very positive to bundle it with Ruby 3.0, but just for case, I'd like to get approval from matz in a public ticket. I hope we can bundle it in 3.0 preview 2.

For TypeProf, please see my talk at RubyKaigi Takeout 2020:

* https://rubykaigi.org/2020-takeout/presentations/mametter.html
* https://www.youtube.com/watch?v=6KcFdQWp8W0



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:100609] [Ruby master Feature#17266] Bundle TypeProf
  2020-10-19 14:55 [ruby-core:100428] [Ruby master Feature#17266] Bundle TypeProf mame
                   ` (2 preceding siblings ...)
  2020-10-27 14:10 ` [ruby-core:100605] " mame
@ 2020-10-27 18:08 ` eregontp
  2020-10-28  0:40 ` [ruby-core:100614] " mame
  2020-10-28 12:19 ` [ruby-core:100620] " eregontp
  5 siblings, 0 replies; 7+ messages in thread
From: eregontp @ 2020-10-27 18:08 UTC (permalink / raw)
  To: ruby-core

Issue #17266 has been updated by Eregon (Benoit Daloze).


Since TypeProf [depends on CRuby bytecodes](https://github.com/ruby/typeprof/blob/master/lib/typeprof/iseq.rb), probably it should be excluded on alternative implementations since it won't work?
Or maybe still ship it but raise a nice error if used on `RUBY_ENGINE != "ruby"`?

I think there might be expectations that all bundled gems for a given version are available on all Ruby implementations.

----------------------------------------
Feature #17266: Bundle TypeProf
https://bugs.ruby-lang.org/issues/17266#change-88240

* Author: mame (Yusuke Endoh)
* Status: Closed
* Priority: Normal
* Assignee: mame (Yusuke Endoh)
----------------------------------------
I'm working on bundling [TypeProf](https://github.com/ruby/typeprof), a type analyzer for non-annotated Ruby code, with Ruby 3.0.  The following PR bundles TypeProf as a bundled gem.

https://github.com/ruby/ruby/pull/3668

Matz was very positive to bundle it with Ruby 3.0, but just for case, I'd like to get approval from matz in a public ticket. I hope we can bundle it in 3.0 preview 2.

For TypeProf, please see my talk at RubyKaigi Takeout 2020:

* https://rubykaigi.org/2020-takeout/presentations/mametter.html
* https://www.youtube.com/watch?v=6KcFdQWp8W0



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:100614] [Ruby master Feature#17266] Bundle TypeProf
  2020-10-19 14:55 [ruby-core:100428] [Ruby master Feature#17266] Bundle TypeProf mame
                   ` (3 preceding siblings ...)
  2020-10-27 18:08 ` [ruby-core:100609] " eregontp
@ 2020-10-28  0:40 ` mame
  2020-10-28 12:19 ` [ruby-core:100620] " eregontp
  5 siblings, 0 replies; 7+ messages in thread
From: mame @ 2020-10-28  0:40 UTC (permalink / raw)
  To: ruby-core

Issue #17266 has been updated by mame (Yusuke Endoh).


> maybe still ship it but raise a nice error if used on RUBY_ENGINE != "ruby"?

Okay, I'll add it.

> I think there might be expectations that all bundled gems for a given version are available on all Ruby implementations.

Sorry. In (far) future, I'd like to improve TypeProf to use AST instead of bytecodes if this project is considered successful. But it requires huge development resource, and there are still many TODOs for typeprof develpoment, so I cannot afford it in near future. (Some people including matz involved in the design of typeprof, but I have developed it alone.)

----------------------------------------
Feature #17266: Bundle TypeProf
https://bugs.ruby-lang.org/issues/17266#change-88245

* Author: mame (Yusuke Endoh)
* Status: Closed
* Priority: Normal
* Assignee: mame (Yusuke Endoh)
----------------------------------------
I'm working on bundling [TypeProf](https://github.com/ruby/typeprof), a type analyzer for non-annotated Ruby code, with Ruby 3.0.  The following PR bundles TypeProf as a bundled gem.

https://github.com/ruby/ruby/pull/3668

Matz was very positive to bundle it with Ruby 3.0, but just for case, I'd like to get approval from matz in a public ticket. I hope we can bundle it in 3.0 preview 2.

For TypeProf, please see my talk at RubyKaigi Takeout 2020:

* https://rubykaigi.org/2020-takeout/presentations/mametter.html
* https://www.youtube.com/watch?v=6KcFdQWp8W0



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [ruby-core:100620] [Ruby master Feature#17266] Bundle TypeProf
  2020-10-19 14:55 [ruby-core:100428] [Ruby master Feature#17266] Bundle TypeProf mame
                   ` (4 preceding siblings ...)
  2020-10-28  0:40 ` [ruby-core:100614] " mame
@ 2020-10-28 12:19 ` eregontp
  5 siblings, 0 replies; 7+ messages in thread
From: eregontp @ 2020-10-28 12:19 UTC (permalink / raw)
  To: ruby-core

Issue #17266 has been updated by Eregon (Benoit Daloze).


mame (Yusuke Endoh) wrote in #note-5:
> Okay, I'll add it.

Thanks.

> Sorry. In (far) future, I'd like to improve TypeProf to use AST instead of bytecodes if this project is considered successful. But it requires huge development resource, and there are still many TODOs for typeprof develpoment, so I cannot afford it in near future. (Some people including matz involved in the design of typeprof, but I have developed it alone.)

I think it's not a big issue if TypeProf is meant only as a CLI/standalone tool, and not a gem to `require` at runtime.
Then people can generate .rbs files on CRuby, but still do everything else on any other Ruby implementation.

(the AST has more information than bytecode, so I guess it could be useful for TypeProf, but it might be more work to process it)

----------------------------------------
Feature #17266: Bundle TypeProf
https://bugs.ruby-lang.org/issues/17266#change-88253

* Author: mame (Yusuke Endoh)
* Status: Closed
* Priority: Normal
* Assignee: mame (Yusuke Endoh)
----------------------------------------
I'm working on bundling [TypeProf](https://github.com/ruby/typeprof), a type analyzer for non-annotated Ruby code, with Ruby 3.0.  The following PR bundles TypeProf as a bundled gem.

https://github.com/ruby/ruby/pull/3668

Matz was very positive to bundle it with Ruby 3.0, but just for case, I'd like to get approval from matz in a public ticket. I hope we can bundle it in 3.0 preview 2.

For TypeProf, please see my talk at RubyKaigi Takeout 2020:

* https://rubykaigi.org/2020-takeout/presentations/mametter.html
* https://www.youtube.com/watch?v=6KcFdQWp8W0



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-10-28 12:19 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 14:55 [ruby-core:100428] [Ruby master Feature#17266] Bundle TypeProf mame
2020-10-19 22:04 ` [ruby-core:100432] " matz
2020-10-27 11:25 ` [ruby-core:100598] " hsbt
2020-10-27 14:10 ` [ruby-core:100605] " mame
2020-10-27 18:08 ` [ruby-core:100609] " eregontp
2020-10-28  0:40 ` [ruby-core:100614] " mame
2020-10-28 12:19 ` [ruby-core:100620] " eregontp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).