From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 34D471F4B4 for ; Fri, 23 Oct 2020 04:10:16 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id B105C120BB6; Fri, 23 Oct 2020 13:09:34 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 453D3120B95 for ; Fri, 23 Oct 2020 13:09:32 +0900 (JST) Received: by filterdrecv-p3iad2-786ff7f994-mbn47 with SMTP id filterdrecv-p3iad2-786ff7f994-mbn47-19-5F9257A0-12 2020-10-23 04:10:08.123336451 +0000 UTC m=+12721.478234546 Received: from herokuapp.com (unknown) by ismtpd0093p1iad2.sendgrid.net (SG) with ESMTP id YGCgJM70QtWhXBhHYWcv8A for ; Fri, 23 Oct 2020 04:10:08.108 +0000 (UTC) Date: Fri, 23 Oct 2020 04:10:08 +0000 (UTC) From: merch-redmine@jeremyevans.net Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 76381 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 6087 X-Redmine-Issue-Author: marcandre X-Redmine-Issue-Assignee: matz X-Redmine-Sender: jeremyevans0 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?RVE3t853K5scBhbmJHUzZTFFeVC=2FZSUmHZ0Dc+26wcEi2CTgsF1oz0wTSSxGGN?= =?us-ascii?Q?BI5jNJUNQQjMbOM8mwl5Xe=2FhYN4=2F9viGDjdNqdB?= =?us-ascii?Q?Plqly56ItbvKdO3FkSaqDyN7vRmy768DzS2KdCX?= =?us-ascii?Q?5jjVd8z3rpvet234ijj78tlGZ4AczBY7Uk1AUPd?= =?us-ascii?Q?V4Z3gJ1gKX2s3eOWwR=2FMRHEIUBi1fGCHFsQf=2Fql?= =?us-ascii?Q?fSOcKt=2F=2FKZ2pIoxhc=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 100511 Subject: [ruby-core:100511] [Ruby master Bug#6087] How should inherited methods deal with return values of their own subclass? X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #6087 has been updated by jeremyevans0 (Jeremy Evans). matz (Yukihiro Matsumoto) wrote in #note-13: > Should we do an experiment in 3.0? I've added a pull request that modifies the Array methods to return Array instances instead of subclass instances: https://github.com/ruby/ruby/pull/3690 ---------------------------------------- Bug #6087: How should inherited methods deal with return values of their own subclass? https://bugs.ruby-lang.org/issues/6087#change-88134 * Author: marcandre (Marc-Andre Lafortune) * Status: Assigned * Priority: Normal * Assignee: matz (Yukihiro Matsumoto) * Target version: 3.0 * ruby -v: trunk ---------------------------------------- Just noticed that we still don't have a consistent way to handle return values: ```ruby class A < Array end a = A.new a.flatten.class # => A a.rotate.class # => Array (a * 2).class # => A (a + a).class # => Array ``` Some methods are even inconsistent depending on their arguments: ```ruby a.slice!(0, 1).class # => A a.slice!(0..0).class # => A a.slice!(0, 0).class # => Array a.slice!(1, 0).class # => Array a.slice!(1..0).class # => Array ``` Finally, there is currently no constructor nor hook called when making these new copies, so they are never properly constructed. Imagine this simplified class that relies on `@foo` holding a hash: ```ruby class A < Array def initialize(*args) super @foo = {} end def initialize_copy(orig) super @foo = @foo.dup end end a = A.new.flatten a.class # => A a.instance_variable_get(:@foo) # => nil, should never happen ``` I feel this violates object orientation. One solution is to always return the base class (`Array`/`String`/...). Another solution is to return the current subclass. To be object oriented, I feel we must do an actual `dup` of the object, including copying the instance variables, if any, and calling `initialize_copy`. Exceptions to this would be (1) explicit documentation, e.g. `Array#to_a`, or (2) methods inherited from a module (like `Enumerable` methods for `Array`). I'll be glad to fix these once there is a decision made on which way to go. -- https://bugs.ruby-lang.org/