From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 17A671F4B4 for ; Wed, 7 Oct 2020 22:31:57 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 5852B120ACA; Thu, 8 Oct 2020 07:31:17 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 1A53C120AC7 for ; Thu, 8 Oct 2020 07:31:14 +0900 (JST) Received: by filterdrecv-p3las1-6f66587546-nnxcm with SMTP id filterdrecv-p3las1-6f66587546-nnxcm-20-5F7E41D2-7F 2020-10-07 22:31:46.846896918 +0000 UTC m=+1384394.175350032 Received: from herokuapp.com (unknown) by geopod-ismtpd-5-6 (SG) with ESMTP id pKtWtcduRrq48WV0dkgSfQ for ; Wed, 07 Oct 2020 22:31:46.594 +0000 (UTC) Date: Wed, 07 Oct 2020 22:31:46 +0000 (UTC) From: samuel@oriontransfer.net Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 76205 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17221 X-Redmine-Issue-Author: ko1 X-Redmine-Sender: ioquatix X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?cjxb6GWHefMLoR50bkJBcGo6DRiDl=2FNYcMZdY+Wj30RfliOKlpFvExpM6=2F8yGu?= =?us-ascii?Q?GLXjcKBvJbRc91mjc7eMerDZemMEhAfsmhA0AGa?= =?us-ascii?Q?aVggOpGlzkW9knIcfYCi=2FIhknPY7abJBMWzaB8b?= =?us-ascii?Q?5QTnmYilmW10ujgKTPhrn46rHm2t2mMxaQ3COJa?= =?us-ascii?Q?SkAHrRxnjMZGzg+ik0GLrkg96YjNFdAcgLjLAP2?= =?us-ascii?Q?1FQ5NT2lg2pjG=2FJfA=3D?= To: ruby-core@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-core X-Mail-Count: 100339 Subject: [ruby-core:100339] [Ruby master Bug#17221] Relax the Fiber#transfer's limitation X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17221 has been updated by ioquatix (Samuel Williams). Great work everyone! ---------------------------------------- Bug #17221: Relax the Fiber#transfer's limitation https://bugs.ruby-lang.org/issues/17221#change-87951 * Author: ko1 (Koichi Sasada) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Using `Fiber#transfer` with `Fiber#resume` for a same Fiber is limited (once `Fiber#transfer` is called for a fiber, the fiber can not be resumed more). ```ruby require 'fiber' f1 = nil f2 = Fiber.new{ f1.transfer } f1 = Fiber.new{ f2.transfer Fiber.yield 10 Fiber.yield 20 } p f1.resume #=> 10 p f1.resume #=> `resume': cannot resume transferred Fiber (FiberError) ``` This restriction was introduced to protect the resume/yield chain, but we realized that it is too much to protect the chain. Instead of the current restriction, we introduce some other protections. (1) can not transfer to the resuming fiber. ```ruby require 'fiber' root = Fiber.current f1 = f2 = nil f1 = Fiber.new{ f2 = Fiber.new{ root.transfer(10) } f2.resume } p f1.transfer #=> 10 # root <-----+ # | | # v | transfer # f1 -> f2 -+ # resume/yield chain # horizontal direction: resume # vertical direction: transfer p f1.transfer #=> attempt to transfer to a resuming fiber (FiberError) # f1 has it's own resume/yield chain, and f1.transfer breaks the chain # root <-----+ # || (error)| # vv | # f1 -> f2 -+ # resume/yield chain ``` (2) can not transfer to the yielding fiber. ```ruby require 'fiber' f1 = f2 = nil f1 = Fiber.new{ f2 = Fiber.new{ Fiber.yield } f2.resume 10 } p f1.transfer #=> 10 # root # | ^ # | | transfer # v | # f1 --> f2 # resume/yield chain # <-- p f2.transfer #=> attempt to transfer to a resuming fiber (FiberError) # f2 is waiting for the resume, so the transfer is not allowed. # root --+ # | ^ | transfer (error) # | | | # v | v # f1 --> f2 # resume/yield chain # <-- ``` (3) can not resume transferring fiber. ```ruby require 'fiber' f1 = f2 = nil f2 = Fiber.new{ f1.resume #=> attempt to resume the transferring fiber (FiberError) } f1 = Fiber.new{ f2.transfer } f1.transfer # root # | # v # f1 <-+ # | | # v | resume (error) # f2 --+ # f1 seems waiting for transfer from other fibers. ``` and remove current restriction. The first example works fine: ```ruby require 'fiber' f1 = nil f2 = Fiber.new{ f1.transfer } f1 = Fiber.new{ f2.transfer Fiber.yield 10 Fiber.yield 20 } p f1.resume #=> 10 p f1.resume #=> 20 # root -> f1 <-+ # | | # v | # f2 --+ ``` The basic idea is respect *programmer's intention*. For (1), resuming fiber should be switched by the `Fiber.yield`. For (2), yielding fiber should be switched by the `Fiber#resume`. For (3), transferring fiber should be switched by the `Fiber#transfer`. Mainly (1) can keep the resume/yield chain. Also (2) and (3) makes the chain and relationships with fibers cleanly. ---- Also at the end of a transferred fiber, it had continued on root fiber. However, if the root fiber resumed a fiber (and that fiber can resumed another fiber), this behavior also breaks the resume/yield chain. So at the end of a transferred fiber, switch to the edge of resume chain from root fiber. For example, root fiber resumed f1 and f1 resumed f2, transferred to f3 and f3 terminated, then continue from the fiber f2 (it was continued from root fiber without this patch). ```ruby require 'fiber' f3 = Fiber.new{ 10 } f2 = Fiber.new{ f3.transfer + 20 } f1 = Fiber.new{ f2.resume } p f1.resume #=> 30 # without this patch: # # root -> f1 -> f2 # ^ | # | exit v # +----------- f3 # with this patch: # # root -> f1 -> f2 <-+ # keep resume/yield chain # | | # v | # f3 --+ exit ``` The patch is: https://github.com/ruby/ruby/pull/3636 ---Files-------------------------------- clipboard-202010080257-u2lbv.png (25.5 KB) -- https://bugs.ruby-lang.org/