From: eregontp@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:100331] [Ruby master Bug#17188] Freeze Encoding objects for Ractor
Date: Wed, 07 Oct 2020 16:02:08 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-87907.20201007160208.772@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-17188.20200925143143.772@ruby-lang.org
Issue #17188 has been updated by Eregon (Benoit Daloze).
Backport set to 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
ruby -v set to ruby 3.0.0preview1 (2020-09-25 master 0096d2b895) [x86_64-linux]
Assignee set to ko1 (Koichi Sasada)
Tracker changed from Feature to Bug
Changing this to a bug, because it can cause unsafe sharing:
```ruby
irb(main):003:0> Encoding::UTF_8.instance_variable_set(:@foo, Object.new)
=> #<Object:0x00005596506b8a28>
irb(main):004:0> Ractor.new { p "b".encoding.instance_variable_get("@foo") }
#<Object:0x00005596506b8a28>
```
----------------------------------------
Bug #17188: Freeze Encoding objects for Ractor
https://bugs.ruby-lang.org/issues/17188#change-87907
* Author: Eregon (Benoit Daloze)
* Status: Open
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Target version: 3.0
* ruby -v: ruby 3.0.0preview1 (2020-09-25 master 0096d2b895) [x86_64-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
Currently Encoding objects are not frozen:
```
$ ruby -ve 'p Encoding::US_ASCII.frozen?'
ruby 3.0.0dev (2020-09-25T08:28:42Z master 81dc37b1b4) [x86_64-linux]
false
```
That means they cannot be accessed in a Ractor:
```ruby
irb(main):001:0> Encoding::US_ASCII
=> #<Encoding:US-ASCII>
irb(main):002:0> Ractor.new { Encoding::US_ASCII }
<internal:ractor>:38: warning: Ractor is experimental, and the behavior may change in future versions of Ruby! Also there are many implementation issues.
=> #<Ractor:#2 (irb):2 running>
#<Thread:0x00005567521d81e8 run> terminated with exception (report_on_exception is true):
(irb):2:in `block in irb_binding': can not access non-sharable objects in constant Encoding::US_ASCII by non-main Ractor. (NameError)
```
And `Ractor.new { p "".encoding }` is likely violating the Ractor guarantees.
I think we can make all Encoding instances frozen.
Making them frozen is also useful for code sharing, which TruffleRuby aims to support via the GraalVM Engine/Context API.
cc @ko1
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2020-10-07 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 14:31 [ruby-core:100148] [Ruby master Feature#17188] Freeze Encoding objects for Ractor eregontp
2020-10-07 16:02 ` eregontp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-87907.20201007160208.772@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).