From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id F23201F4B4 for ; Tue, 6 Oct 2020 21:06:35 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 8F01C120AB4; Wed, 7 Oct 2020 06:05:57 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id ED637120A97 for ; Wed, 7 Oct 2020 06:05:54 +0900 (JST) Received: by filterdrecv-p3iad2-df8579867-jh7wc with SMTP id filterdrecv-p3iad2-df8579867-jh7wc-18-5F7CDC54-49 2020-10-06 21:06:28.577407116 +0000 UTC m=+1292873.260475485 Received: from herokuapp.com (unknown) by ismtpd0025p1iad2.sendgrid.net (SG) with ESMTP id J6104e7fS36_p_OIM3XKkQ for ; Tue, 06 Oct 2020 21:06:28.414 +0000 (UTC) Date: Tue, 06 Oct 2020 21:06:28 +0000 (UTC) From: shannonskipper@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 76155 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 13683 X-Redmine-Issue-Author: dnagir X-Redmine-Sender: shan X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?T0jc+HUEV7CM5SiK=2FBdwdf6zPPpzUxEkATeka3QtAYpXkVFLM=2FnKrcWp2gjrBh?= =?us-ascii?Q?ZS3t4mcDZ6t35wV68rtgsxB=2F7=2FXxFJsGWhX7mrb?= =?us-ascii?Q?fuqMUDIN2gJ0UaRxSnsoZ0FrlNP6JKfZ8YCjC2r?= =?us-ascii?Q?8pPOyQMON2phgwr6yjGsBQUPD5SicYr5gGpILet?= =?us-ascii?Q?PYy4ihbxicqnjX0KMdw663ZKspbpPY2T3bJg=2FnS?= =?us-ascii?Q?EbJilNaGLPlqtcryw=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 100316 Subject: [ruby-core:100316] [Ruby master Feature#13683] Add strict Enumerable#single X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13683 has been updated by shan (Shannon Skipper). ``` ruby [42] in [sole]; sole #=> 42 [] in [sole]; sole #!> NoMatchingPatternError ([]) [42, 43] in [sole]; sole #!> NoMatchingPatternError ([42, 43]) ``` For Arrays, pattern matching seems reasonable. Wouldn't that not work for other Enumerable collections? ``` ruby Set.new([42]) in [sole]; sole #!> NoMatchingPatternError (#) ``` It seems it an Enumerable# method would be more slick and nice for method chaining. ``` ruby Set.new([42]).sole #=> 42 Set.new([42]).sole.digits #=> [2, 4] ``` ---------------------------------------- Feature #13683: Add strict Enumerable#single https://bugs.ruby-lang.org/issues/13683#change-87897 * Author: dnagir (Dmytrii Nagirniak) * Status: Feedback * Priority: Normal ---------------------------------------- ### Summary This is inspired by other languages and frameworks, such as LINQ's [Single](https://msdn.microsoft.com/en-us/library/bb155325%28v=vs.110%29.aspx) (pardon MSDN reference), which has very big distinction between `first` and `single` element of a collection. - `first` normally returns the top element, and the developer assumes there could be many; - `single` returns one and only one element, and it is an error if there are none or more than one. We, in Ruby world, very often write `fetch_by('something').first` assuming there's only one element that can be returned there. But in majority of the cases, we really want a `single` element. The problems with using `first` in this case: - developer needs to explicitly double check the result isn't `nil` - in case of corrupted data (more than one item returned), it will never be noticed `Enumerable#single` addresses those problems in a very strong and specific way that may save the world by simply switching from `first` to `single`. ### Other information - we may come with a better internal implementation (than `self.map`) - better name could be used, maybe `only` is better, or a bang version? - re-consider the "block" implementation in favour of a separate method (`single!`, `single_or { 'default' }`) The original implementation is on the ActiveSupport https://github.com/rails/rails/pull/26206 But it was suggested to discuss the possibility of adding it to Ruby which would be amazing. -- https://bugs.ruby-lang.org/