From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id A8E791F4B4 for ; Fri, 25 Sep 2020 05:04:08 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 145CC120AC9; Fri, 25 Sep 2020 14:03:33 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 96EDF120AC8 for ; Fri, 25 Sep 2020 14:03:31 +0900 (JST) Received: by filterdrecv-p3mdw1-5dd6bc5999-dmlv2 with SMTP id filterdrecv-p3mdw1-5dd6bc5999-dmlv2-20-5F6D7A43-5C 2020-09-25 05:04:03.727691518 +0000 UTC m=+284733.311905282 Received: from herokuapp.com (unknown) by ismtpd0134p1mdw1.sendgrid.net (SG) with ESMTP id M1-HHYIaTHyILWJ_c-RWzA for ; Fri, 25 Sep 2020 05:04:03.665 +0000 (UTC) Date: Fri, 25 Sep 2020 05:04:03 +0000 (UTC) From: shyouhei@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 75960 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 17143 X-Redmine-Issue-Author: jeremyevans0 X-Redmine-Sender: shyouhei X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?jcfQDMoo=2FMGCmP3uu1SeyLQUxUPXq5PjHpHz3xSFn17EIoKjmf8cz2us8c5Oji?= =?us-ascii?Q?77FkPpgelAd1HFdNlFCKRpo3=2FykATMV65VfDIQK?= =?us-ascii?Q?EQSxRIM+AYXp6uRR8aS1CZjmdBDjWXqz3iKGi5l?= =?us-ascii?Q?yC3DNQ8nVzxkhJKKMulclWQpckLiKTT2y7+yh7f?= =?us-ascii?Q?hvNx2zaJEeZTvb1mIU1eRwQkImIF=2FFP3t3aZJ=2FL?= =?us-ascii?Q?LcOhlnYTepnp2DyLY=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 100120 Subject: [ruby-core:100120] [Ruby master Feature#17143] Improve support for warning categories X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17143 has been updated by shyouhei (Shyouhei Urabe). - I'm not against adding the category keyword. However, - I guess it is quite hard for us to +1 the "Add categories for all core warnings" commit at once. - It might contain OK changes, but might also contain questionable ones. - Do you really need to do this in a big changeset like this? Can you split it into each categories, and let us consider case-by-case? ---------------------------------------- Feature #17143: Improve support for warning categories https://bugs.ruby-lang.org/issues/17143#change-87688 * Author: jeremyevans0 (Jeremy Evans) * Status: Open * Priority: Normal ---------------------------------------- Support was recently added for Warning.warn to accept a `category` keyword. However, the initial implementation was limited to having `rb_warn_deprecated` and `rb_warn_deprecated_to_remove` use the `:deprecated` value for the `category` keyword. It doesn't make sense to me to have a `category` keyword if it is only used for deprecation, so I propose we extend the support so that `Kernel#warn` accepts a category keyword (for Ruby-level warnings) and `rb_category_warn` and `rb_category_warning` functions be added to the C-API (for C-level warnings). I also propose that we change existing `rb_warn` and `rb_warning` calls to `rb_category_warn` and `rb_category_warning`, so that all warnings issued by core Ruby are issued with an appropriate category. I have implemented support for this in a pull request: https://github.com/ruby/ruby/pull/3508 -- https://bugs.ruby-lang.org/