From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id DF2491F66E for ; Mon, 31 Aug 2020 19:28:16 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 9C948120A29; Tue, 1 Sep 2020 04:27:41 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 17FA2120A28 for ; Tue, 1 Sep 2020 04:27:39 +0900 (JST) Received: by filterdrecv-p3iad2-787bb5c9bc-md54p with SMTP id filterdrecv-p3iad2-787bb5c9bc-md54p-20-5F4D4F44-7A 2020-08-31 19:28:04.957385236 +0000 UTC m=+350895.877688291 Received: from herokuapp.com (unknown) by ismtpd0021p1iad2.sendgrid.net (SG) with ESMTP id pGqPYcMaT9acLxNJWmQG7Q for ; Mon, 31 Aug 2020 19:28:04.931 +0000 (UTC) Date: Mon, 31 Aug 2020 19:28:05 +0000 (UTC) From: eregontp@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 75635 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 17104 X-Redmine-Issue-Author: bughit X-Redmine-Issue-Assignee: Eregon X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?KippOI8ZHtTweq7XfQzW93937kJ4QNWwSBuHnaMEcr2CAlMrbPxfjRh50AinVD?= =?us-ascii?Q?5K1aho2YmEoZGwersxV61USt44IEnTRYLTaDkb0?= =?us-ascii?Q?1X0UjGY00Q3DAHU4n=2FzKd8wyVV+EkdSb7j0ZLEE?= =?us-ascii?Q?RBEMP1AK60hubqOa1RZrYtlMSATpJMYeadHya5o?= =?us-ascii?Q?aeQ75v=2F6aZq+oy2zYSJPeES345xJVzGj7lOi0f0?= =?us-ascii?Q?dSbM5WUucMUWzTDwM=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99802 Subject: [ruby-core:99802] [Ruby master Feature#17104] Do not freeze interpolated strings when using frozen-string-literal X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17104 has been updated by Eregon (Benoit Daloze). Assignee set to Eregon (Benoit Daloze) I'll try to make a PR for this change. ---------------------------------------- Feature #17104: Do not freeze interpolated strings when using frozen-string-literal https://bugs.ruby-lang.org/issues/17104#change-87322 * Author: bughit (bug hit) * Status: Open * Priority: Normal * Assignee: Eregon (Benoit Daloze) ---------------------------------------- I think the point of frozen string literals is to avoid needless allocations. Interpolated strings are allocated each time, so freezing them appears pointless. ```rb #frozen_string_literal: true def foo(str) "#{str}" end fr1 = 'a' fr2 = 'a' fr1_1 = foo(fr1) fr2_1 = foo(fr2) puts fr1.__id__, fr2.__id__, fr1_1.__id__, fr2_1.__id__ puts fr1_1 << 'b' ``` -- https://bugs.ruby-lang.org/