From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id C86FD1F66E for ; Thu, 27 Aug 2020 08:03:15 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id C0D74120A81; Thu, 27 Aug 2020 17:02:42 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id C1C51120A80 for ; Thu, 27 Aug 2020 17:02:40 +0900 (JST) Received: by filterdrecv-p3iad2-56cd58c948-tzn2k with SMTP id filterdrecv-p3iad2-56cd58c948-tzn2k-18-5F4768BE-14 2020-08-27 08:03:10.299377113 +0000 UTC m=+35065.945607470 Received: from herokuapp.com (unknown) by ismtpd0092p1mdw1.sendgrid.net (SG) with ESMTP id -PtHDbwiRQOpnXkXpUilgA for ; Thu, 27 Aug 2020 08:03:10.150 +0000 (UTC) Date: Thu, 27 Aug 2020 08:03:10 +0000 (UTC) From: fatkodima123@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 75562 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17030 X-Redmine-Issue-Author: marcandre X-Redmine-Sender: fatkodima X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?RvZ0H4gD69HjmyxuoEldmMenU4znNUKl7mOsZIogdq69QzSA=2F1dNePImYWVEkb?= =?us-ascii?Q?ZFA7A5gQmhWBC21zLmADU+uDpF2rgJyRnvolt1m?= =?us-ascii?Q?yjSBO1gKizmf8lSljsGDSxPRNThfoODo0G65i7N?= =?us-ascii?Q?xyZtg7uho=2FxMuEy97CocSQ90AWAE+hAHtqeAKfI?= =?us-ascii?Q?R1y9yZFj7VL8jRLJHaIa84c9cOwjBAVzJMQEZH9?= =?us-ascii?Q?us6EdonNaj1KhpIcc=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99729 Subject: [ruby-core:99729] [Ruby master Bug#17030] Enumerable#grep{_v} should be optimized for Regexp X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17030 has been updated by fatkodima (Dima Fatko). Dan0042 (Daniel DeLorme) wrote in #note-15: > > So a simpler approach would be to check if the match operation's scope (in this case the method body) contains any of the regexp-related pseudo-globals. I didn't quite get it. So, to summarize, how this new approach should work? Can you elaborate in few more sentences? Does ruby already do some kind of static analysis that you can point me to? ---------------------------------------- Bug #17030: Enumerable#grep{_v} should be optimized for Regexp https://bugs.ruby-lang.org/issues/17030#change-87222 * Author: marcandre (Marc-Andre Lafortune) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Currently, ```ruby array.select { |e| e.match?(REGEXP) } ``` is about three times faster and six times more memory efficient than ```ruby array.grep(REGEXP) ``` This is because `grep` calls `Regexp#===`, which creates useless `MatchData`. -- https://bugs.ruby-lang.org/