From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 0F4B01F66E for ; Thu, 27 Aug 2020 02:10:12 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id A8D441209F6; Thu, 27 Aug 2020 11:09:38 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id E84041209F5 for ; Thu, 27 Aug 2020 11:09:35 +0900 (JST) Received: by filterdrecv-p3iad2-56cd58c948-pvv8z with SMTP id filterdrecv-p3iad2-56cd58c948-pvv8z-18-5F4715F8-28 2020-08-27 02:10:00.471004892 +0000 UTC m=+13869.164328926 Received: from herokuapp.com (unknown) by geopod-ismtpd-1-3 (SG) with ESMTP id 59kJ0nuiShqZW6AmtvOQeQ for ; Thu, 27 Aug 2020 02:10:00.381 +0000 (UTC) Date: Thu, 27 Aug 2020 02:10:00 +0000 (UTC) From: marcandre-ruby-core@marc-andre.ca Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 75555 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17030 X-Redmine-Issue-Author: marcandre X-Redmine-Sender: marcandre X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?6=2FIMxCQLDposcQf5wmbDAtfaKduBAO0bKyhL3BGZtMQ5q7K2TvpbN6A7JIyt9E?= =?us-ascii?Q?aOZLeIqbp0+x19=2FroUosS0xJIkUzp5LpxYaPLJv?= =?us-ascii?Q?IMFJfnB=2FB99UkHVh7V0UVw84PxapzA2YW0lhWDD?= =?us-ascii?Q?3WQoXhrVIMa2OrvSNb2m5+ERoyPWToqyCqXvkIx?= =?us-ascii?Q?zMXZwUKWZgpMDrm40S4Vn2PPaZNJ3SAz5TOPK1r?= =?us-ascii?Q?ycEicP8LAXVCXTqtgoW2P31V2EeCQ59wgbfbtI?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99722 Subject: [ruby-core:99722] [Ruby master Bug#17030] Enumerable#grep{_v} should be optimized for Regexp X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17030 has been updated by marcandre (Marc-Andre Lafortune). Dan0042 (Daniel DeLorme) wrote in #note-17: > Maybe not impossible, but personally I wouldn't want to code that kind of analysis when a simple approach is enough for >90% of cases, and guaranteed to be bug-free. Agreed > > There will be other false positives: `str.gsub(regexp, &block)`. That's not a real issue, simply assume that `block` will want access to `Regexp.last_match`. > > Actually... `block` does not have access to `Regexp.last_match` (unless you created the block in the same scope as the gsub operation, but that would be unusual) You are right, my bad. ---------------------------------------- Bug #17030: Enumerable#grep{_v} should be optimized for Regexp https://bugs.ruby-lang.org/issues/17030#change-87213 * Author: marcandre (Marc-Andre Lafortune) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Currently, ```ruby array.select { |e| e.match?(REGEXP) } ``` is about three times faster and six times more memory efficient than ```ruby array.grep(REGEXP) ``` This is because `grep` calls `Regexp#===`, which creates useless `MatchData`. -- https://bugs.ruby-lang.org/