From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id E51201F66E for ; Wed, 26 Aug 2020 20:27:39 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id E3B4E120A49; Thu, 27 Aug 2020 05:27:04 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 5D2D5120A48 for ; Thu, 27 Aug 2020 05:27:03 +0900 (JST) Received: by filterdrecv-p3las1-84969bf46d-lq8xp with SMTP id filterdrecv-p3las1-84969bf46d-lq8xp-18-5F46C5B3-22 2020-08-26 20:27:31.588523363 +0000 UTC m=+9594.250364114 Received: from herokuapp.com (unknown) by ismtpd0103p1mdw1.sendgrid.net (SG) with ESMTP id 4_iLSYucTLyE0fs9DpeU7Q for ; Wed, 26 Aug 2020 20:27:31.479 +0000 (UTC) Date: Wed, 26 Aug 2020 20:27:31 +0000 (UTC) From: XrXr@users.noreply.github.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 75548 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17048 X-Redmine-Issue-Author: alanwu X-Redmine-Sender: alanwu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?PWg67P6owy8ojUUZg1G=2FQM4Z0jTQ2XLCqLM8Y2L8tUvRFuUPM6+aKANjRFY5CJ?= =?us-ascii?Q?rINAJJafY08xSGXFwgEG7xNws8G2E0M6fIklSZJ?= =?us-ascii?Q?wt0xGGZBxMTzO4IJJaM4YmSPgxgs3eloo0GICQx?= =?us-ascii?Q?L6lRjRj9hb2D+eaN+zeD7DhA1hZUMDt1l79XJnM?= =?us-ascii?Q?boypvwhX3SS=2FheVlQ0=2FMbc7Hcqx6qWvArMc843r?= =?us-ascii?Q?S+LMvThp7PyeGfs9o=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99715 Subject: [ruby-core:99715] [Ruby master Bug#17048] Calling initialize_copy on live modules leads to crashes X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17048 has been updated by alanwu (Alan Wu). Yes, nobu's patch fixes the crash. It is technically a breaking change though, so maybe it needs approval from Matz? Side note, the bug still exists on master as of [today](https://wandbox.org/permlink/afSmo1UbL9wnIBmq). ---------------------------------------- Bug #17048: Calling initialize_copy on live modules leads to crashes https://bugs.ruby-lang.org/issues/17048#change-87205 * Author: alanwu (Alan Wu) * Status: Open * Priority: Normal * ruby -v: ruby 2.8.0dev (2020-07-23T14:44:25Z master 098e8c2873) [x86_64-linux] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Here's a repro script ```ruby loop do m = Module.new do prepend Module.new def hello end end klass = Class.new { include m } m.send(:initialize_copy, Module.new) GC.start klass.new.hello rescue nil end ``` Here's a script that shows that it has broken semantics even when it happens to not crash. ```ruby module A end class B include A end module C Const = :C end module D Const = :D end A.send(:initialize_copy, C) p B::Const # :C, makes sense A.send(:initialize_copy, D) p B::Const # :D, makes sense A.send(:initialize_copy, Module.new) p (begin B::Const rescue NameError; 'NameError' end) # NameError, makes sense A.send(:initialize_copy, C) p B::Const # still NameErorr. Weird ``` This example shows that the problem exists [as far back as 2.0.0](https://wandbox.org/permlink/4dVDY9sNXJ803jh8). I think the easiest way to fix this is to forbid calling `:initialize_copy` on modules that have children. Another option is to try to decide on the semantics of this. Though I don't think it's worth the effort as this has been broken for a long time and people don't seem to to be using it. Thoughts? -- https://bugs.ruby-lang.org/