From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 1AD671F66E for ; Wed, 26 Aug 2020 19:31:58 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 40F36120A44; Thu, 27 Aug 2020 04:31:24 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 64C88120A43 for ; Thu, 27 Aug 2020 04:31:21 +0900 (JST) Received: by filterdrecv-p3las1-84969bf46d-qwf66 with SMTP id filterdrecv-p3las1-84969bf46d-qwf66-20-5F46B8A6-6F 2020-08-26 19:31:50.594935807 +0000 UTC m=+6264.721400980 Received: from herokuapp.com (unknown) by ismtpd0066p1mdw1.sendgrid.net (SG) with ESMTP id D2fpeqdWRAKM_t-rJgnhvw for ; Wed, 26 Aug 2020 19:31:50.413 +0000 (UTC) Date: Wed, 26 Aug 2020 19:31:50 +0000 (UTC) From: marcandre-ruby-core@marc-andre.ca Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 75547 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17030 X-Redmine-Issue-Author: marcandre X-Redmine-Sender: marcandre X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?6=2FIMxCQLDposcQf5wmbDAtfaKduBAO0bKyhL3BGZtMQ5q7K2TvpbN6A7JIyt9E?= =?us-ascii?Q?aOsRXVSEqqkIqncdvMgyRZegF5WGqkZwa6w2zLl?= =?us-ascii?Q?Sq+xyQYhIRKntlB+1dIafEyzcsW7zg=2FQI906Q8T?= =?us-ascii?Q?7MLvCQj=2Fxjx84q5QhslXDJIkrTVgKncTfgP2EC8?= =?us-ascii?Q?s+N3tWOHDNZI2S=2FTpETZxwT11Nkkn7jgJElmbPt?= =?us-ascii?Q?5JDvNkwHtPBroMpesRfdWVbD9p=2FrAZ9ooQh2NR?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99714 Subject: [ruby-core:99714] [Ruby master Bug#17030] Enumerable#grep{_v} should be optimized for Regexp X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17030 has been updated by marcandre (Marc-Andre Lafortune). Dan0042 (Daniel DeLorme) wrote in #note-15: > But static analysis has other limits Good example but it is easily resolved: assume `v` isn't a Regexp and we may get a false positive, which is not a big issue. There will be other false positives: `str.gsub(regexp, &block)`. That's not a real issue, simply assume that `block` will want access to `Regexp.last_match`. I'm really only worried about false negatives... Any other example comes to mind? ---------------------------------------- Bug #17030: Enumerable#grep{_v} should be optimized for Regexp https://bugs.ruby-lang.org/issues/17030#change-87204 * Author: marcandre (Marc-Andre Lafortune) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Currently: ```ruby array.select { |e| e.match?(REGEXP) } # about 3x faster and 6x more memory efficient than array.grep(REGEXP) ``` This is because `grep` calls `Regexp#===` which creates useless `MatchData` -- https://bugs.ruby-lang.org/