From: merch-redmine@jeremyevans.net
To: ruby-core@ruby-lang.org
Subject: [ruby-core:99392] [Ruby master Bug#17058] Array#delete_if doesn't change array instantly
Date: Wed, 29 Jul 2020 15:33:32 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-86796.20200729153332.42257@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-17058.20200729151855.42257@ruby-lang.org
Issue #17058 has been updated by jeremyevans0 (Jeremy Evans).
Looks like this changed between Ruby 2.2 and 2.3. I'll update the documentation to remove the line, as I think it's an implementation detail (that is now wrong).
----------------------------------------
Bug #17058: Array#delete_if doesn't change array instantly
https://bugs.ruby-lang.org/issues/17058#change-86796
* Author: erik_schlyter (Erik Schlyter)
* Status: Open
* Priority: Normal
* ruby -v: ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
According to the documentation: https://ruby-doc.org/core-2.7.1/Array.html#method-i-delete_if
"The array is changed instantly every time the block is called, not after the iteration is over."
I've tried printing the array while iterating it:
```
a = [1,2,3,4,5,6,7]
a.delete_if{|x|
puts "During iteration: #{a}"
x % 2 == 0
}
puts "After iteration: #{a}"
```
The output is as follows:
```
During iteration: [1, 2, 3, 4, 5, 6, 7]
During iteration: [1, 2, 3, 4, 5, 6, 7]
During iteration: [1, 2, 3, 4, 5, 6, 7]
During iteration: [1, 3, 3, 4, 5, 6, 7]
During iteration: [1, 3, 3, 4, 5, 6, 7]
During iteration: [1, 3, 5, 4, 5, 6, 7]
During iteration: [1, 3, 5, 4, 5, 6, 7]
After iteration: [1, 3, 5, 7]
```
This functionality has changed somewhere between 2.2.2 and 2.4.0. When I use "ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]", I get the following (correct) output:
```
During iteration: [1, 2, 3, 4, 5, 6, 7]
During iteration: [1, 2, 3, 4, 5, 6, 7]
During iteration: [1, 3, 4, 5, 6, 7]
During iteration: [1, 3, 4, 5, 6, 7]
During iteration: [1, 3, 5, 6, 7]
During iteration: [1, 3, 5, 6, 7]
During iteration: [1, 3, 5, 7]
After iteration: [1, 3, 5, 7]
```
When I use "ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]" or the latest (2.7.1), I get the wrong output.
The functionality doesn't seem crucial, but the documentation should be correct.
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2020-07-29 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 15:18 [ruby-core:99390] [Ruby master Bug#17058] Array#delete_if doesn't change array instantly erik
2020-07-29 15:33 ` merch-redmine [this message]
2020-07-29 15:37 ` [ruby-core:99394] " merch-redmine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-86796.20200729153332.42257@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).