From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 58BA71F5AE for ; Sat, 25 Jul 2020 02:35:32 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id E78D61209DB; Sat, 25 Jul 2020 11:34:58 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 55C2E1209D4 for ; Sat, 25 Jul 2020 11:34:56 +0900 (JST) Received: by filterdrecv-p3iad2-5b55dcd864-kvwkt with SMTP id filterdrecv-p3iad2-5b55dcd864-kvwkt-20-5F1B9A68-B 2020-07-25 02:35:20.12530011 +0000 UTC m=+2453155.600170385 Received: from herokuapp.com (unknown) by ismtpd0033p1iad2.sendgrid.net (SG) with ESMTP id YDD9CE3HRO2R61U5AV1kxw for ; Sat, 25 Jul 2020 02:35:20.086 +0000 (UTC) Date: Sat, 25 Jul 2020 02:35:20 +0000 (UTC) From: nobu@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 75112 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17048 X-Redmine-Issue-Author: alanwu X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?q8Dly+pU2+3ektTtZVXgZtbJPXwqo7p86jCsvYTW4BznyEHFqr9NlQBeeju7Fl?= =?us-ascii?Q?jFHTxte9Y94lqVklWFwmhfTfDq26ZOWEUen7iFi?= =?us-ascii?Q?uS7++m2qdNf2wYe0cAv+sv5WkcjGvxnzqiyx3dR?= =?us-ascii?Q?RKCT6UyaFukk=2FUyANfsaDYuQuGVDb2gsac9yQoG?= =?us-ascii?Q?JoM=2FBajo0hIr4l7KXacYO9J5XOReEG9VGBdMXE+?= =?us-ascii?Q?8tbvcZ2tS8M5Ajvm8=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99321 Subject: [ruby-core:99321] [Ruby master Bug#17048] Calling initialize_copy on live modules leads to crashes X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17048 has been updated by nobu (Nobuyoshi Nakada). I agree with @alanwu, that it won't be worth. ```diff diff --git c/class.c i/class.c index 6835d2d7289..f7a56601634 100644 --- c/class.c +++ i/class.c @@ -354,6 +354,13 @@ static void ensure_origin(VALUE klass); VALUE rb_mod_init_copy(VALUE clone, VALUE orig) { + if (RCLASS_EXT(clone)->subclasses || + RCLASS_EXT(clone)->parent_subclasses || + RCLASS_EXT(clone)->module_subclasses) { + rb_raise(rb_eTypeError, "cannot replace %s in use", + (RB_TYPE_P(clone, T_MODULE) ? "module" : "class")); + } + /* cloned flag is refer at constant inline cache * see vm_get_const_key_cref() in vm_insnhelper.c */ diff --git c/test/ruby/test_module.rb i/test/ruby/test_module.rb index d2da384cbd1..8d986f13413 100644 --- c/test/ruby/test_module.rb +++ i/test/ruby/test_module.rb @@ -435,6 +435,12 @@ assert_empty(m.constants, bug9813) end + def test_initialize_copy_in_use + m = Module.new + Class.new {include m} + assert_raise(TypeError) {m.send(:initialize_copy, Module.new)} + end + def test_dup OtherSetup.call ``` ---------------------------------------- Bug #17048: Calling initialize_copy on live modules leads to crashes https://bugs.ruby-lang.org/issues/17048#change-86715 * Author: alanwu (Alan Wu) * Status: Open * Priority: Normal * ruby -v: ruby 2.8.0dev (2020-07-23T14:44:25Z master 098e8c2873) [x86_64-linux] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Here's a repro script ```ruby loop do m = Module.new do prepend Module.new def hello end end klass = Class.new { include m } m.send(:initialize_copy, Module.new) GC.start klass.new.hello rescue nil end ``` Here's a script that shows that it has broken semantics even when it happens to not crash. ```ruby module A end class B include A end module C Const = :C end module D Const = :D end A.send(:initialize_copy, C) p B::Const # :C, makes sense A.send(:initialize_copy, D) p B::Const # :D, makes sense A.send(:initialize_copy, Module.new) p (begin B::Const rescue NameError; 'NameError' end) # NameError, makes sense A.send(:initialize_copy, C) p B::Const # still NameErorr. Weird ``` This example shows that the problem exists [as far back as 2.0.0](https://wandbox.org/permlink/4dVDY9sNXJ803jh8). I think the easiest way to fix this is to forbid calling `:initialize_copy` on modules that have children. Another option is to try to decide on the semantics of this. Though I don't think it's worth the effort as this has been broken for a long time and people don't seem to to be using it. Thoughts? -- https://bugs.ruby-lang.org/