From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id DC98C1F5AE for ; Tue, 14 Jul 2020 13:28:32 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 40FDA120A1A; Tue, 14 Jul 2020 22:27:58 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 589CB120A08 for ; Tue, 14 Jul 2020 22:27:53 +0900 (JST) Received: by filterdrecv-p3iad2-5b55dcd864-l2x6n with SMTP id filterdrecv-p3iad2-5b55dcd864-l2x6n-19-5F0DB2F2-98 2020-07-14 13:28:18.601257341 +0000 UTC m=+1541937.233007461 Received: from herokuapp.com (unknown) by ismtpd0019p1iad2.sendgrid.net (SG) with ESMTP id ctRXabcGRi26d2eTzfeaag for ; Tue, 14 Jul 2020 13:28:18.543 +0000 (UTC) Date: Tue, 14 Jul 2020 13:28:18 +0000 (UTC) From: eregontp@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 74955 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17030 X-Redmine-Issue-Author: marcandre X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?KippOI8ZHtTweq7XfQzW93937kJ4QNWwSBuHnaMEcr24p4FIJkYXCnLiofyKCJ?= =?us-ascii?Q?kUJKyX+UOtf2BPaCOqfDh0vw=2F9AS7Zuhd3WIiYh?= =?us-ascii?Q?G5JGDMuKhwHLDkSeHIzooCAGKC3GEgLqapNIb3P?= =?us-ascii?Q?u76qPZrc+967IMyi9MyS2zNE0TmNo2KBSjqF2wd?= =?us-ascii?Q?CzB9nLYYxZ2+GwscI+dSkRq6cJ0YEj6j52UzdxI?= =?us-ascii?Q?z=2Fu1R79i0JsYUcilA=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99165 Subject: [ruby-core:99165] [Ruby master Bug#17030] Enumerable#grep{_v} should be optimized for Regexp X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17030 has been updated by Eregon (Benoit Daloze). nobu (Nobuyoshi Nakada) wrote in #note-4: > Even without a block, `grep` sets `$~` to the last match result. I guess cases using `$~` after the call to `grep` are very rare (notably because only the last match of the Enumerable would be accessible). So I would suggest not setting `$~` for `grep` without block. ---------------------------------------- Bug #17030: Enumerable#grep{_v} should be optimized for Regexp https://bugs.ruby-lang.org/issues/17030#change-86543 * Author: marcandre (Marc-Andre Lafortune) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Currently: ```ruby array.select { |e| e.match?(REGEXP) } # about 3x faster and 6x more memory efficient than array.grep(REGEXP) ``` This is because `grep` calls `Regexp#===` which creates useless `MatchData` -- https://bugs.ruby-lang.org/