From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 5C9191F5AE for ; Tue, 14 Jul 2020 10:25:26 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 2AC62120A15; Tue, 14 Jul 2020 19:24:55 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 0608B120941 for ; Tue, 14 Jul 2020 19:24:52 +0900 (JST) Received: by filterdrecv-p3iad2-5b55dcd864-v6r54 with SMTP id filterdrecv-p3iad2-5b55dcd864-v6r54-19-5F0D880E-41 2020-07-14 10:25:18.767582298 +0000 UTC m=+1530952.614592120 Received: from herokuapp.com (unknown) by ismtpd0014p1iad2.sendgrid.net (SG) with ESMTP id A4GvWGglSc-CwhO5uw6xGA for ; Tue, 14 Jul 2020 10:25:18.680 +0000 (UTC) Date: Tue, 14 Jul 2020 10:25:18 +0000 (UTC) From: nobu@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 74954 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17030 X-Redmine-Issue-Author: marcandre X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?q8Dly+pU2+3ektTtZVXgZtbJPXwqo7p86jCsvYTW4BywioSub2dHgMdwcK3ZQb?= =?us-ascii?Q?bRelewnbzvK=2FziBLRZ2ElKSzBrVzxmEQVRS=2FA60?= =?us-ascii?Q?7=2FFCjUH=2FR29uNE=2FFvLdMNWbQ=2FxDrkUlrC8w3xmo?= =?us-ascii?Q?qkpEreVkjfxVomAuft1vAtD1utKhLmRhF7M9bsJ?= =?us-ascii?Q?cUUVPhIS=2FkvaHctTd4aQM1CJ1Im8LeWfzm6L0S0?= =?us-ascii?Q?X6vXuZbDYWVVOYb4w=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99164 Subject: [ruby-core:99164] [Ruby master Bug#17030] Enumerable#grep{_v} should be optimized for Regexp X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17030 has been updated by nobu (Nobuyoshi Nakada). Even without a block, `grep` sets `$~` to the last match result. ---------------------------------------- Bug #17030: Enumerable#grep{_v} should be optimized for Regexp https://bugs.ruby-lang.org/issues/17030#change-86542 * Author: marcandre (Marc-Andre Lafortune) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Currently: ```ruby array.select { |e| e.match?(REGEXP) } # about 3x faster and 6x more memory efficient than array.grep(REGEXP) ``` This is because `grep` calls `Regexp#===` which creates useless `MatchData` -- https://bugs.ruby-lang.org/