From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id A7A791F5AE for ; Tue, 14 Jul 2020 03:37:13 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 32CD0120A36; Tue, 14 Jul 2020 12:36:43 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id AF14B120A33 for ; Tue, 14 Jul 2020 12:36:40 +0900 (JST) Received: by filterdrecv-p3iad2-5b55dcd864-rnx82 with SMTP id filterdrecv-p3iad2-5b55dcd864-rnx82-18-5F0D2862-2D 2020-07-14 03:37:06.678254726 +0000 UTC m=+1506471.315003627 Received: from herokuapp.com (unknown) by ismtpd0111p1mdw1.sendgrid.net (SG) with ESMTP id pbROZik5SgWuf8fyZlWL9g for ; Tue, 14 Jul 2020 03:37:06.610 +0000 (UTC) Date: Tue, 14 Jul 2020 03:37:06 +0000 (UTC) From: marcandre-ruby-core@marc-andre.ca Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 74953 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17030 X-Redmine-Issue-Author: marcandre X-Redmine-Sender: marcandre X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?6=2FIMxCQLDposcQf5wmbDAtfaKduBAO0bKyhL3BGZtMQ5q7K2TvpbN6A7JIyt9E?= =?us-ascii?Q?aOUyyiVQr1hGd1fizwDljnWga142BA2P25PCph7?= =?us-ascii?Q?1t9UVws=2Fif2+jL2DQy418WXeZW9nMf=2FTIsIwyXZ?= =?us-ascii?Q?N35D+J8oEMDoM=2F2QD=2F7W4B+CLLM8Q=2Fbj4qeeNl1?= =?us-ascii?Q?pkiSR4=2FK6U57PCz6awkRNTRhkutbGpGquFENF86?= =?us-ascii?Q?yXZbfvxGtzv=2FNIvwyeMdNnusIZmpnsBcct2I3F?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99163 Subject: [ruby-core:99163] [Ruby master Bug#17030] Enumerable#grep{_v} should be optimized for Regexp X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17030 has been updated by marcandre (Marc-Andre Lafortune). You are right for `grep` with a block, we can't necessarily optimize, but we should optimize `grep` without a block, no? ---------------------------------------- Bug #17030: Enumerable#grep{_v} should be optimized for Regexp https://bugs.ruby-lang.org/issues/17030#change-86541 * Author: marcandre (Marc-Andre Lafortune) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Currently: ```ruby array.select { |e| e.match?(REGEXP) } # about 3x faster and 6x more memory efficient than array.grep(REGEXP) ``` This is because `grep` calls `Regexp#===` which creates useless `MatchData` -- https://bugs.ruby-lang.org/