From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id B1AD91F5AE for ; Tue, 14 Jul 2020 01:24:29 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 102501209E9; Tue, 14 Jul 2020 10:23:58 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 0AB0E12097C for ; Tue, 14 Jul 2020 10:23:55 +0900 (JST) Received: by filterdrecv-p3mdw1-75c584b9c6-4xwkm with SMTP id filterdrecv-p3mdw1-75c584b9c6-4xwkm-18-5F0D0945-20 2020-07-14 01:24:21.560176655 +0000 UTC m=+1498484.041636741 Received: from herokuapp.com (unknown) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id VYqzdliwQDywD_oX8tOmbA for ; Tue, 14 Jul 2020 01:24:21.485 +0000 (UTC) Date: Tue, 14 Jul 2020 01:24:21 +0000 (UTC) From: shyouhei@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 74951 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17030 X-Redmine-Issue-Author: marcandre X-Redmine-Sender: shyouhei X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?jcfQDMoo=2FMGCmP3uu1SeyLQUxUPXq5PjHpHz3xSFn14tp+FtaoAXFwK7ir3sMS?= =?us-ascii?Q?ioCyGG+z0NF03HAY094H+l+3LAdyZn5mYiyZEnf?= =?us-ascii?Q?YKeTvHZx0A98Ts4EUEX7DBtRjHEv7KSB0hkDycm?= =?us-ascii?Q?a6hYVQixBsz+y9wBjq6GAr9Th721w+ojW5YHUX4?= =?us-ascii?Q?3mBWQzhJup+mIBOjoEqP11X0yi0w6LGI3X6UmH5?= =?us-ascii?Q?xO1cbILHXlcm8+MGc=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99161 Subject: [ruby-core:99161] [Ruby master Bug#17030] Enumerable#grep{_v} should be optimized for Regexp X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17030 has been updated by shyouhei (Shyouhei Urabe). Yes but E#grep's allocating MatchData is by spec. You can observe `$&` etc. by passing a block to it. ```ruby p %w[q w e r].grep(/./) { $~ } ``` So this is at least a breaking change. ---------------------------------------- Bug #17030: Enumerable#grep{_v} should be optimized for Regexp https://bugs.ruby-lang.org/issues/17030#change-86539 * Author: marcandre (Marc-Andre Lafortune) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Currently: ```ruby array.select { |e| e.match?(REGEXP) } # about 3x faster and 6x more memory efficient than array.grep(REGEXP) ``` This is because `grep` calls `Regexp#===` which creates useless `MatchData` -- https://bugs.ruby-lang.org/