From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 278FA1F5AE for ; Mon, 13 Jul 2020 20:27:55 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 3DB53120A06; Tue, 14 Jul 2020 05:27:26 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 06B21120A04 for ; Tue, 14 Jul 2020 05:27:23 +0900 (JST) Received: by filterdrecv-p3iad2-5b55dcd864-l2x6n with SMTP id filterdrecv-p3iad2-5b55dcd864-l2x6n-19-5F0CC3C6-34 2020-07-13 20:27:50.493128764 +0000 UTC m=+1480709.124878879 Received: from herokuapp.com (unknown) by geopod-ismtpd-2-3 (SG) with ESMTP id 9Ybot2ezQICR5P-bzqZTSA for ; Mon, 13 Jul 2020 20:27:50.481 +0000 (UTC) Date: Mon, 13 Jul 2020 20:27:50 +0000 (UTC) From: marcandre-ruby-core@marc-andre.ca Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 74947 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17030 X-Redmine-Issue-Author: marcandre X-Redmine-Sender: marcandre X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?6=2FIMxCQLDposcQf5wmbDAtfaKduBAO0bKyhL3BGZtMQ5q7K2TvpbN6A7JIyt9E?= =?us-ascii?Q?aOPkCqsrusXMUEuMsx0=2FseTGr+SpQlPeW9j0msN?= =?us-ascii?Q?9WeHBSC0Ao4qyp4UFit=2F5H9TlOQZWpEKaMgOpwR?= =?us-ascii?Q?Ltpukw2k9v8SZNTUJIex81OfIxJvf9czZwcw2WI?= =?us-ascii?Q?fB=2FeJfmbiqQn+nwhA=2Fs6ybBi1sX8agQxb8CfBrq?= =?us-ascii?Q?frMk3FudKdOu7CVV2b3N6ryOuIOcpulz+kroOT?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99157 Subject: [ruby-core:99157] [Ruby master Bug#17030] Enumerable#grep{_v} should be optimized for Regexp X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17030 has been updated by marcandre (Marc-Andre Lafortune). Code to reproduce: ```ruby require 'benchmark-ips' require 'benchmark-memory' arr = %w[foobar foobaz bazquux hello world just making this array longer] REGEXP = /o/ def select_match(arr) arr.select { |e| e.match?(REGEXP) } end def grep(arr) arr.grep(REGEXP) end Benchmark.ips do |x| x.report("select.match?") { select_match(arr) } x.report("grep") { grep(arr) } x.compare! end puts "********* MEMORY *********" Benchmark.memory do |x| x.report("select.match?") { select_match(arr) } x.report("grep") { grep(arr) } x.compare! end ``` ---------------------------------------- Bug #17030: Enumerable#grep{_v} should be optimized for Regexp https://bugs.ruby-lang.org/issues/17030#change-86535 * Author: marcandre (Marc-Andre Lafortune) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Currently: ```ruby array.select { |e| e.match?(REGEXP) } # about 3x faster and 6x more memory efficient than array.grep(REGEXP) ``` This is because `grep` calls `Regexp#===` which creates useless `MatchData` -- https://bugs.ruby-lang.org/