From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 1B7701F5AE for ; Tue, 7 Jul 2020 20:43:35 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id CC05D12097F; Wed, 8 Jul 2020 05:43:05 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 0B3C112097E for ; Wed, 8 Jul 2020 05:43:03 +0900 (JST) Received: by filterdrecv-p3mdw1-75c584b9c6-qfkhm with SMTP id filterdrecv-p3mdw1-75c584b9c6-qfkhm-21-5F04DE71-46 2020-07-07 20:43:29.755450138 +0000 UTC m=+963237.268897422 Received: from herokuapp.com (unknown) by ismtpd0016p1iad2.sendgrid.net (SG) with ESMTP id TSUkHe2yT7mai3uGKJHJ3Q for ; Tue, 07 Jul 2020 20:43:29.722 +0000 (UTC) Date: Tue, 07 Jul 2020 20:43:29 +0000 (UTC) From: bosticko@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 74871 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 17017 X-Redmine-Issue-Author: sambostock X-Redmine-Sender: sambostock X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?=2FfUu9ySTEdIFkNHOx92Y8rGt0ly8q6z7LdBuQfIFYQvVd6GOGzWjHJJVSLUW0A?= =?us-ascii?Q?ae3tz+ep+lf8FnAcZf4f0PBW+Cy0m9n1qMAtSEP?= =?us-ascii?Q?tDy93sbPN7J5RUjHOAbDUKrPMhbzTUxDdyaBUBo?= =?us-ascii?Q?xhVu7vlDk0mVvsnbXA4cThLm+mRX1e0Onff9B=2Fq?= =?us-ascii?Q?laUFFUH151cG2DBvWYlAMW9P7Ot9pagWXF8fyI=2F?= =?us-ascii?Q?7=2FFxwIeCaSoNkm8yM=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 99081 Subject: [ruby-core:99081] [Ruby master Bug#17017] Range#max & Range#minmax incorrectly use Float end as max X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #17017 has been updated by sambostock (Sam Bostock). Description updated Add full array example ---------------------------------------- Bug #17017: Range#max & Range#minmax incorrectly use Float end as max https://bugs.ruby-lang.org/issues/17017#change-86452 * Author: sambostock (Sam Bostock) * Status: Open * Priority: Normal * ruby -v: 2.7.1 * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- While continuing to add edge cases to [`Range#minmax` specs](https://github.com/ruby/spec/pull/777), I discovered the following bug: ```ruby (1..3.1).to_a == [1, 2, 3] # As expected (1..3.1).to_a.max == 3 # As expected (1..3.1).to_a.minmax == [1, 3] # As expected (1..3.1).max == 3.1 # Should be 3, as above (1..3.1).minmax == [1, 3.1] # Should be [1, 3], as above ``` One way to detect this scenario might be to do (whatever the C equivalent is of) ```ruby range_end.is_a?(Numeric) // Is this a numeric range? && (range_end - range_begin).modulo(1) == 0 // Can we reach the range_end using the standard step size (1) ``` As for how to handle it, a couple options come to mind: - We could error out and do something similar to what we do for exclusive ranges ```ruby raise TypeError, 'cannot exclude non Integer end value' ``` - We might be able to calculate the range end by doing something like ```ruby num_steps = (range_end / range_beg).to_i - 1 # one fewer steps than would exceed the range_end max = range_beg + num_steps # take that many steps all at once ``` - We could delegate to `super` and enumerate the range to find the max ```ruby super ``` -- https://bugs.ruby-lang.org/