From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id DAB8A1F55B for ; Tue, 9 Jun 2020 20:43:09 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 0F111120A06; Wed, 10 Jun 2020 05:42:40 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id E024F1208D6 for ; Wed, 10 Jun 2020 05:42:36 +0900 (JST) Received: by filter0084p3las1.sendgrid.net with SMTP id filter0084p3las1-24709-5EDFF453-C4 2020-06-09 20:43:00.072165801 +0000 UTC m=+95608.558033162 Received: from herokuapp.com (unknown) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id 3NAqbiCWTnu3nBHfDfKwqg for ; Tue, 09 Jun 2020 20:42:59.990 +0000 (UTC) Date: Tue, 09 Jun 2020 20:43:00 +0000 (UTC) From: v.ondruch@tiscali.cz Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 74486 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 16936 X-Redmine-Issue-Author: jaruga X-Redmine-Sender: vo.x X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?mWhqNvD1xlBozk4zn6CTHlnSPHlTKkyHJdiOH=2FzC52ijl6pDE6iKP=2FJoylpQcg?= =?us-ascii?Q?pl3xarKxYthca5tOyGbz0gS5IV+ri92qXk9feqU?= =?us-ascii?Q?mnflx5ouog+pdmFFzEeKuQRHLXoSa6phhdo+WuJ?= =?us-ascii?Q?AsdQDkTPKRwu2Ny9oezU+zG0WzXzyy5vx4j0C+Y?= =?us-ascii?Q?ytWksCAv3nkk55hGpYkZv82ngT1Rt3JYvOw=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 98694 Subject: [ruby-core:98694] [Ruby master Bug#16936] `make test-all TESTS="-n !/Foo#method/"` not skipping the test case X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16936 has been updated by vo.x (Vit Ondruch). test-unit in Ruby is thin wrapper above old version of minitest and does not have too much in common with test-unit project. Changing this would be quite big feat. ---------------------------------------- Bug #16936: `make test-all TESTS="-n !/Foo#method/"` not skipping the test case https://bugs.ruby-lang.org/issues/16936#change-86040 * Author: jaruga (Jun Aruga) * Status: Closed * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- On the current latest master `cf1adf985ab78507250db0e217a0fdd779e2c6e6`. ``` $ autoconf $ ./configure --prefix=$(pwd)/dest $ make ``` The following `make test-all` works as I mentioned at #16935. ``` $ make test-all TESTS="-v -n /\^TestBugReporter#test_bug_reporter_add\$$/ -n /\^TestProcess#test_status_quit\$$/" ... [1/0] TestBugReporter#test_bug_reporter_add = 0.41 s [2/0] TestProcess#test_status_quit = 0.35 s Finished tests in 9.392046s, 0.2129 tests/s, 1.5971 assertions/s. 2 tests, 15 assertions, 0 failures, 0 errors, 0 skips ... ``` But it seems that the following `TestBugReporter#test_bug_reporter_add` and `TestProcess#test_status_quit` are not actually skipped. Is it a bug? ``` $ make test-all TESTS="test/-ext-/bug_reporter/test_bug_reporter.rb test/ruby/test_process.rb -v -n \!/\^TestBugReporter#test_bug_reporter_add\$$/ -n \!/\^TestProcess#test_status_quit\$$/" 2>&1 | tee make.log Run options:- --seed=21367 "--ruby=./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems" --excludes-dir=./test/excludes --name=!/memory_leak/ -v -n "!/^TestBugReporter#test_bug_reporter_add$/" -n "!/^TestProcess#test_status_quit$/" # Running tests: [ 1/142] TestBugReporter#test_bug_reporter_add = 0.49 s ... [128/142] TestProcess#test_status_quit = 0.30 s ... Finished tests in 25.978847s, 5.4660 tests/s, 39.2627 assertions/s. 142 tests, 1020 assertions, 0 failures, 0 errors, 0 skips ``` I want to skip the specific test cases by `make test-all TESTS="..."` like this. I want to specify both the testing class (ex. `TestBugReporter`) and method (ex. `test_bug_reporter_add`) with the regular expression perfect matching to avoid unintended test cases are skipped. ``` $ make test-all TESTS="-v -n \!/\^TestBugReporter#test_bug_reporter_add\$$/ -n \!/\^TestProcess#test_status_quit\$$/" ``` The following `make test` works skipping `test_bug_reporter_add` and `test_status_quit` methods. ``` $ make test-all TESTS="test/-ext-/bug_reporter/test_bug_reporter.rb test/ruby/test_process.rb -v -n \!/test_bug_reporter_add\$$/ -n \!/test_status_quit\$$/" 2>&1 | tee make2.log ... 140 tests, 1005 assertions, 0 failures, 0 errors, 0 skips ``` -- https://bugs.ruby-lang.org/