From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id EED7D1F9E0 for ; Fri, 1 May 2020 08:46:39 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 4D7591209D6; Fri, 1 May 2020 17:46:16 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id A5D3C1209D4 for ; Fri, 1 May 2020 17:46:12 +0900 (JST) Received: by filterdrecv-p3mdw1-6dbfd75bfd-h68rz with SMTP id filterdrecv-p3mdw1-6dbfd75bfd-h68rz-18-5EABE1E8-22 2020-05-01 08:46:32.246730804 +0000 UTC m=+3137945.358998614 Received: from herokuapp.com (unknown) by ismtpd0091p1iad2.sendgrid.net (SG) with ESMTP id MY6cGmNgQe-zVLNjQGqbFw for ; Fri, 01 May 2020 08:46:32.155 +0000 (UTC) Date: Fri, 01 May 2020 08:46:32 +0000 (UTC) From: shugo@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 73861 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 16780 X-Redmine-Issue-Author: rgerard X-Redmine-Issue-Assignee: naruse X-Redmine-Sender: shugo X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?A4qw=2FE7uJv6zjRy5ZA2RlSNSopH4PRxwlkqj2Qg3aeRQiMaQAu9LW6q+XCA=2FAD?= =?us-ascii?Q?vIMPLeHM8Ut9NV18Rw8+zYmLu6ZHuLnP2OBJdla?= =?us-ascii?Q?Vc0ko8pohEWXV4KvtgfJEKSI3G4qN8feOsK+kg+?= =?us-ascii?Q?ogxJxSPIenLWW2J81F+OGSeQbEldxQbvqetFi7S?= =?us-ascii?Q?GELe5Fv6B050dF0lKTbsLPSEhand3a44SbhupIP?= =?us-ascii?Q?dpsXtCoAcwycGd7g4=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 98100 Subject: [ruby-core:98100] [Ruby master Bug#16780] Net::FTP PUT command issuing Net::ReadTimeout too quickly X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16780 has been updated by shugo (Shugo Maeda). Assignee set to naruse (Yui NARUSE) Status changed from Open to Assigned @naruse It seems that the change was introduced by your commit. Could you check it? ---------------------------------------- Bug #16780: Net::FTP PUT command issuing Net::ReadTimeout too quickly https://bugs.ruby-lang.org/issues/16780#change-85336 * Author: rgerard (Ryan Gerard) * Status: Assigned * Priority: Normal * Assignee: naruse (Yui NARUSE) * ruby -v: 2.7.1 * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- This is my first time writing up an issue for this community, so I apologize if this is written in an abnormal way than your normal issues. We recently upgraded from ruby 2.6.5 to 2.7.1. Almost immediately, we started seeing issues with some of our application code that utilizes Net::FTP. All calls to #put to an external FTP server we communicate with were resulting in a Net::ReadTimeout exception being throw. Upon examination of the external FTP server, we can see that the file was successfully transferred, although the Net::ReadTimeout exception begin thrown caused confusion on our end. Looking over the changes that were part of the ruby 2.7.0 release, I believe this commit (https://github.com/ruby/ruby/commit/5be34d6a3310065850c0c530db6936415124b5d9), which was a fix for this bug (https://bugs.ruby-lang.org/issues/16413) is the root of the issue. I translated the japanese, and I understand that the change to add the `begin` and `ensure` blocks were to make sure the connection was closed in case an exception is thrown during the transfer. However, the additional change to the connection read_timeout to 1 second was a little puzzling. I can see that this logic was copied from `retrbinary` and `retrlines`, but I'm uncertain why the connection read_timeout should be changed to 1 second. I believe the right fix is to remove the change to the connection read_timeout. Here is the stack trace for the exception we're getting during the call to #put: ``` ruby Net::ReadTimeout with # /usr/local/lib/ruby/2.7.0/net/protocol.rb:217:in `rbuf_fill' /usr/local/lib/ruby/2.7.0/net/protocol.rb:159:in `read' /usr/local/lib/ruby/2.7.0/net/ftp.rb:1475:in `read' /usr/local/lib/ruby/2.7.0/net/ftp.rb:693:in `block (2 levels) in storbinary' /usr/local/lib/ruby/2.7.0/net/ftp.rb:308:in `with_binary' /usr/local/lib/ruby/2.7.0/net/ftp.rb:684:in `block in storbinary' /usr/local/lib/ruby/2.7.0/monitor.rb:202:in `synchronize' /usr/local/lib/ruby/2.7.0/monitor.rb:202:in `mon_synchronize' /usr/local/lib/ruby/2.7.0/net/ftp.rb:683:in `storbinary' /usr/local/lib/ruby/2.7.0/net/ftp.rb:843:in `putbinaryfile' /usr/local/lib/ruby/2.7.0/net/ftp.rb:871:in `put' ``` -- https://bugs.ruby-lang.org/