From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.0 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 0506B1F5AD for ; Mon, 13 Apr 2020 00:59:26 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 6271D120A3B; Mon, 13 Apr 2020 09:51:21 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 8DE16120A38 for ; Mon, 13 Apr 2020 09:51:18 +0900 (JST) Received: by filterdrecv-p3las1-cb48d7cc9-mdp4n with SMTP id filterdrecv-p3las1-cb48d7cc9-mdp4n-19-5E93B798-3 2020-04-13 00:51:36.379946411 +0000 UTC m=+1554255.549103633 Received: from herokuapp.com (unknown) by ismtpd0049p1mdw1.sendgrid.net (SG) with ESMTP id z0C_q7Z7Ra6gIxFEe_2wng for ; Mon, 13 Apr 2020 00:51:36.129 +0000 (UTC) Date: Mon, 13 Apr 2020 00:51:36 +0000 (UTC) From: Greg.mpls@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 73623 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Misc X-Redmine-Issue-Id: 16778 X-Redmine-Issue-Author: deivid X-Redmine-Issue-Assignee: hsbt X-Redmine-Sender: MSP-Greg X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?M4W5dkI32Qt1AHWPzmUKqncwpr1RYzW=2Fh5io+QGCFbot=2FiE=2FdIxjw8KqwlFho5?= =?us-ascii?Q?mzTevpklcIL59gZb8YmxoiXsc9qthCROOWPT4=2Fj?= =?us-ascii?Q?yhuf22iCrgrQKy7VVD8QWofGiErrVomIZ0a0Dr1?= =?us-ascii?Q?WvSXjzzHOx9d0NZT2PAD=2FVkQlrDZeq2Txnkj7MB?= =?us-ascii?Q?EmwwNFGXfGfOJl6mNPOEnl4aOwbs1k35IOEtY1X?= =?us-ascii?Q?tyv+sjJtEDMr9pkoU=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 97862 Subject: [ruby-core:97862] [Ruby master Misc#16778] Should we stop vendoring default gems code? X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16778 has been updated by MSP-Greg (Greg L). CI in general, and in particular Actions (along with actions/checkout@v2) c= an be done from any repo. There could a repo (maybe ruby-std-lib-ci) that contained nothing but Actio= ns workflow scripts using Ruby master for all std-lib repos. For instance,= all jobs could be staggered cron jobs, running as often as desired. Hence, the CI would neither clog up the std-lib repos, nor ruby/ruby. If t= he std-lib repos wanted their own CI to run against Ruby master, they could= certainly do so. This might especially work well for std-lib repos that d= on't have frequent commits. Just one idea... ---------------------------------------- Misc #16778: Should we stop vendoring default gems code? https://bugs.ruby-lang.org/issues/16778#change-85086 * Author: deivid (David Rodr=EDguez) * Status: Assigned * Priority: Normal * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- Currently ruby-core vendors all the code in default gems, and runs the test= s for each of them. Also, ruby-core continuously updates the vendored code of default gems to s= ync with the upstream repos. That's overhead work, not only from syncronizi= ng the code itself, but it also requires perfect syncronization of releases= to avoid including versions of default gems that are different from releas= ed versions. Also, this causes confusion for contributors because the code lives "duplic= ated" in two different places. Some times contributors will open a PR in th= e ruby-core repo, only to find out that they need to go to the upstream rep= o and contribute it in there. And this rule is not even always followed and= sometimes ruby-core contributors apply patches to the vendored code direct= ly (many times to fix test-only issues inherent to the different structure = of the core repository). These patches then need to be contributed back to = the upstream repo. I believe that all of that kind of defeats the point of "gemification" of t= he standard library. Once some ruby code its gemified, it should be the new upstream's responsab= ility to make sure the code works and it's properly tested, and ruby-core s= hould be free'd from that responsability. Maybe ruby-core could do something along the following lines: * Remove all the vendored code from default gems. * When this code is needed for internal tests, manage it as a development d= ependency, clone it as necessary on non source controlled locations, and us= e it from there. * Maybe a file similar to `gems/bundled_gems` can be added for default gems= indicating their versions and upstream repos, to ease things. * Upon `make install`, clone the proper version of each default library and= get it installed in the default $LOAD_PATH. * Maybe add some bare high level CI checks to ensure that all default libra= ries can be properly required after `make install`, and that their executab= les (if they include any) can also be run. This should bring several benefits to the development process: * No more duplicated code. * No more syncronization from upstream to ruby-core. * No more syncronization from ruby-core to upstream. * No more confusion around the canonical place to contribute. * No more complexities derived from the different organization of the code = depending on whether it lives in ruby-core or outside. = I believe jruby already does something like this so it'd be interesting to = get some input from them. If this is a direction the ruby-core team would like to take, I'm happy to = help @hsbt with small steps towards slowly approaching to this high level g= oal. -- = https://bugs.ruby-lang.org/ Unsubscribe: