From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id C972A1F5AD for ; Fri, 10 Apr 2020 16:44:21 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 86560120B41; Sat, 11 Apr 2020 01:44:00 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 7AF93120B3F for ; Sat, 11 Apr 2020 01:43:58 +0900 (JST) Received: by filterdrecv-p3iad2-8ddf98858-cq957 with SMTP id filterdrecv-p3iad2-8ddf98858-cq957-19-5E90A25B-15 2020-04-10 16:44:11.267416491 +0000 UTC m=+1352201.415223270 Received: from herokuapp.com (unknown) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id CIQGE1wgRAqt3FSilK4DnQ for ; Fri, 10 Apr 2020 16:44:11.185 +0000 (UTC) Date: Fri, 10 Apr 2020 16:44:11 +0000 (UTC) From: eregontp@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 73571 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 6087 X-Redmine-Issue-Author: marcandre X-Redmine-Issue-Assignee: matz X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?KippOI8ZHtTweq7XfQzW93937kJ4QNWwSBuHnaMEcr3LaM+l4Hb1D5IxIVKhFf?= =?us-ascii?Q?z8Mxnkm7uyyofjz5v8NGFPPGAo8VC=2FXBmCCu9Y7?= =?us-ascii?Q?Vpr+fEh2=2Fmcw7r4=2F5x8DRnLOogaS5egSyVSkBi=2F?= =?us-ascii?Q?Iwb3Rhc2dlJNGRbjjuaz6G7ygm60NqJ5jDxeXfO?= =?us-ascii?Q?LayXHqyXalpl7ErxY8a1iAAfGaR0KvgP=2FjFDnYx?= =?us-ascii?Q?+uOvsIVyU99qDRcyE=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 97811 Subject: [ruby-core:97811] [Ruby master Bug#6087] How should inherited methods deal with return values of their own subclass? X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #6087 has been updated by Eregon (Benoit Daloze). Much like all Enumerable methods return `Array` and (of course) do not copy instance variables, I think Array methods should do the same. This seems particularly important since Array overrides a few methods from Enumerable for optimization but that should be entirely transparent. For example, returning a subclass in e.g. Array#map would make it inconsistent with Enumerable#map. So I'm in favor of no subclass handling here. We're creating a new instance, and copying the entire state from the receiver doesn't seem reasonable to me. If people want to keep receiver state like class and @ivars, they can always use mutating methods + #dup if needed. ---------------------------------------- Bug #6087: How should inherited methods deal with return values of their own subclass? https://bugs.ruby-lang.org/issues/6087#change-85029 * Author: marcandre (Marc-Andre Lafortune) * Status: Assigned * Priority: Normal * Assignee: matz (Yukihiro Matsumoto) * Target version: 3.0 * ruby -v: trunk ---------------------------------------- Just noticed that we still don't have a consistent way to handle return values: ```ruby class A < Array end a = A.new a.flatten.class # => A a.rotate.class # => Array (a * 2).class # => A (a + a).class # => Array ``` Some methods are even inconsistent depending on their arguments: ```ruby a.slice!(0, 1).class # => A a.slice!(0..0).class # => A a.slice!(0, 0).class # => Array a.slice!(1, 0).class # => Array a.slice!(1..0).class # => Array ``` Finally, there is currently no constructor nor hook called when making these new copies, so they are never properly constructed. Imagine this simplified class that relies on `@foo` holding a hash: ```ruby class A < Array def initialize(*args) super @foo = {} end def initialize_copy(orig) super @foo = @foo.dup end end a = A.new.flatten a.class # => A a.instance_variable_get(:@foo) # => nil, should never happen ``` I feel this violates object orientation. One solution is to always return the base class (`Array`/`String`/...). Another solution is to return the current subclass. To be object oriented, I feel we must do an actual `dup` of the object, including copying the instance variables, if any, and calling `initialize_copy`. Exceptions to this would be (1) explicit documentation, e.g. `Array#to_a`, or (2) methods inherited from a module (like `Enumerable` methods for `Array`). I'll be glad to fix these once there is a decision made on which way to go. -- https://bugs.ruby-lang.org/