From: merch-redmine@jeremyevans.net
To: ruby-core@ruby-lang.org
Subject: [ruby-core:97512] [Ruby master Bug#16519] pp [Hash.ruby2_keywords_hash({})] shows `[nil]`
Date: Sun, 15 Mar 2020 21:15:52 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-84661.20200315211552.772@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16519.20200121230717.772@ruby-lang.org
Issue #16519 has been updated by jeremyevans0 (Jeremy Evans).
Eregon (Benoit Daloze) wrote in #note-18:
> @jeremyevans0 Could you take a look for the 2.7 backport?
Sure, I'll take a look tomorrow and see if I can fix it locally and submit a pull request for the ruby_2_7 branch.
----------------------------------------
Bug #16519: pp [Hash.ruby2_keywords_hash({})] shows `[nil]`
https://bugs.ruby-lang.org/issues/16519#change-84661
* Author: Eregon (Benoit Daloze)
* Status: Closed
* Priority: Normal
* Assignee: jeremyevans0 (Jeremy Evans)
* ruby -v: ruby 2.8.0dev (2020-01-21T13:45:10Z master 5798d35ff6) [x86_64-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: REQUIRED
----------------------------------------
This happens on `master`:
```
$ ruby -ve 'ruby2_keywords def flag(*a); a.last; end; pp [flag(**{})]'
ruby 2.8.0dev (2020-01-21T13:45:10Z master 5798d35ff6) [x86_64-linux]
[nil]
```
Of course it should be `[{}]`, as it is for `pp [{}]`.
On 2.7.0 it warns (should be fixed, it's valid to `pp` a flagged Hash):
```
$ ruby -ve 'ruby2_keywords def flag(*a); a.last; end; pp [flag(**{})]'
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux]
[/home/eregon/.rubies/ruby-2.7.0/lib/ruby/2.7.0/pp.rb:226: warning: Passing the keyword argument as the last hash parameter is deprecated
/home/eregon/.rubies/ruby-2.7.0/lib/ruby/2.7.0/pp.rb:334: warning: The called method is defined here
{}]
```
The warning being in the middle of the output is a fun fact here.
Lines it refers to (still the same on current master):
https://github.com/ruby/ruby/blob/v2_7_0/lib/pp.rb#L226
https://github.com/ruby/ruby/blob/v2_7_0/lib/pp.rb#L334
This is very confusing as it can happen during `test-all` and then show output such as:
```
<[{:a=>1}]> expected but was
<[{:a=>1}, nil]>.
```
when the reality is (can be verified with `p` before the `assert_equal`):
```
<[{:a=>1}]> expected but was
<[{:a=>1}, {}]>.
```
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2020-03-15 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-16519.20200121230717.772@ruby-lang.org>
2020-03-13 14:30 ` [ruby-core:97486] [Ruby master Bug#16519] pp [Hash.ruby2_keywords_hash({})] shows `[nil]` naruse
2020-03-14 6:39 ` [ruby-core:97489] " naruse
2020-03-14 11:21 ` [ruby-core:97494] " eregontp
2020-03-15 12:04 ` [ruby-core:97505] " naruse
2020-03-15 16:09 ` [ruby-core:97508] " eregontp
2020-03-15 21:15 ` merch-redmine [this message]
2020-03-16 16:29 ` [ruby-core:97529] " merch-redmine
2020-07-23 8:02 ` [ruby-core:99293] " nagachika00
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-84661.20200315211552.772@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).