[ruby-core:53159] [ruby-trunk - Feature #8026][Open] Need Module#prepended_modules

[ruby-core:53159] [ruby-trunk - Feature #8026][Open] Need Module#prepended_modules

[marcandre (Marc-Andre Lafortune)]

Issue #8026 has been reported by marcandre (Marc-Andre Lafortune).

----------------------------------------
Feature #8026: Need Module#prepended_modules
https://bugs.ruby-lang.org/issues/8026

Author: marcandre (Marc-Andre Lafortune)
Status: Open
Priority: Normal
Assignee: matz (Yukihiro Matsumoto)
Category: core
Target version: current: 2.1.0


We should have a way to get the list of prepended modules of a class or module.

    module Mixin
    end

    module Outer
      prepend Mixin
    end

    Mixin.prepended_modules   #=> []
    Outer.prepended_modules   #=> [Mixin]

See also bug #8025.


-- 
http://bugs.ruby-lang.org/

[ruby-core:56216] [ruby-trunk - Feature #8026] Need Module#prepended_modules

[matz (Yukihiro Matsumoto)]

Issue #8026 has been updated by matz (Yukihiro Matsumoto).


I am OK with the idea.

Matz.

----------------------------------------
Feature #8026: Need Module#prepended_modules
https://bugs.ruby-lang.org/issues/8026#change-40704

Author: marcandre (Marc-Andre Lafortune)
Status: Open
Priority: Normal
Assignee: matz (Yukihiro Matsumoto)
Category: core
Target version: current: 2.1.0


We should have a way to get the list of prepended modules of a class or module.

    module Mixin
    end

    module Outer
      prepend Mixin
    end

    Mixin.prepended_modules   #=> []
    Outer.prepended_modules   #=> [Mixin]

See also bug #8025.


-- 
http://bugs.ruby-lang.org/

[ruby-core:56222] [ruby-trunk - Feature #8026] Need Module#prepended_modules

[knu (Akinori MUSHA)]

Issue #8026 has been updated by knu (Akinori MUSHA).


What about adding Module#prepend?(other) also, which could be implemented in ruby as follows?

module Module
  def prepend?(other)
    ancestors.find { |mod|
      break false if mod == self
      mod == other
    }
  end
end

----------------------------------------
Feature #8026: Need Module#prepended_modules
https://bugs.ruby-lang.org/issues/8026#change-40710

Author: marcandre (Marc-Andre Lafortune)
Status: Open
Priority: Normal
Assignee: matz (Yukihiro Matsumoto)
Category: core
Target version: current: 2.1.0


We should have a way to get the list of prepended modules of a class or module.

    module Mixin
    end

    module Outer
      prepend Mixin
    end

    Mixin.prepended_modules   #=> []
    Outer.prepended_modules   #=> [Mixin]

See also bug #8025.


-- 
http://bugs.ruby-lang.org/

[ruby-core:56899] [ruby-trunk - Feature #8026] Need Module#prepended_modules

[marcandre (Marc-Andre Lafortune)]

Issue #8026 has been updated by marcandre (Marc-Andre Lafortune).

File prepended.pdf added

Slide added. I'm also proposing an optional flag to search only the receiver and not the ancestors.

I didn't put in `prepend?` but it should also be added. On the other hand, `Array.prepend?(Enumerable)` should return false, no?
----------------------------------------
Feature #8026: Need Module#prepended_modules
https://bugs.ruby-lang.org/issues/8026#change-41444

Author: marcandre (Marc-Andre Lafortune)
Status: Open
Priority: Normal
Assignee: matz (Yukihiro Matsumoto)
Category: core
Target version: current: 2.1.0


We should have a way to get the list of prepended modules of a class or module.

    module Mixin
    end

    module Outer
      prepend Mixin
    end

    Mixin.prepended_modules   #=> []
    Outer.prepended_modules   #=> [Mixin]

See also bug #8025.


-- 
http://bugs.ruby-lang.org/

[ruby-core:56917] [ruby-trunk - Feature #8026][Feedback] Need Module#prepended_modules

[matz (Yukihiro Matsumoto)]

Issue #8026 has been updated by matz (Yukihiro Matsumoto).

Status changed from Open to Feedback

I basically accept the idea.

But according to the slide, the optional `include_ancestors` is true, but it does mean cherry-picking prepended modules from ancestor list.  I cannot think of any use case of this behavior.

Matz.


----------------------------------------
Feature #8026: Need Module#prepended_modules
https://bugs.ruby-lang.org/issues/8026#change-41468

Author: marcandre (Marc-Andre Lafortune)
Status: Feedback
Priority: Normal
Assignee: matz (Yukihiro Matsumoto)
Category: core
Target version: current: 2.1.0


We should have a way to get the list of prepended modules of a class or module.

    module Mixin
    end

    module Outer
      prepend Mixin
    end

    Mixin.prepended_modules   #=> []
    Outer.prepended_modules   #=> [Mixin]

See also bug #8025.


-- 
http://bugs.ruby-lang.org/

[ruby-core:60283] [ruby-trunk - Feature #8026] Need Module#prepended_modules

[shibata.hiroshi]

Issue #8026 has been updated by Hiroshi SHIBATA.

Target version changed from 2.1.0 to current: 2.2.0

----------------------------------------
Feature #8026: Need Module#prepended_modules
https://bugs.ruby-lang.org/issues/8026#change-44765

* Author: Marc-Andre Lafortune
* Status: Feedback
* Priority: Normal
* Assignee: Yukihiro Matsumoto
* Category: core
* Target version: current: 2.2.0
----------------------------------------
We should have a way to get the list of prepended modules of a class or module.

    module Mixin
    end

    module Outer
      prepend Mixin
    end

    Mixin.prepended_modules   #=> []
    Outer.prepended_modules   #=> [Mixin]

See also bug #8025.

---Files--------------------------------
prepended.pdf (99.4 KB)


-- 
http://bugs.ruby-lang.org/

[ruby-core:96347] [Ruby master Feature#8026] Need Module#prepended_modules

[mame]

Issue #8026 has been updated by mame (Yusuke Endoh).


matz (Yukihiro Matsumoto) wrote:
> But according to the slide, the optional `include_ancestors` is true, but it does mean cherry-picking prepended modules from ancestor list.  I cannot think of any use case of this behavior.

I guess `include_ancestors` here means "modules prepended by prepended modules":

```
module A; end
module B; prepend A; end
module C; prepend B; end

C.prepended_modules(true)  #=> [A, B]
C.prepended_modules(false) #=> [B]
```

So, `include_ancestors` is not a good name; should it be called `include_descendants`?

@marcandre , am I right?

----------------------------------------
Feature #8026: Need Module#prepended_modules
https://bugs.ruby-lang.org/issues/8026#change-83258

* Author: marcandre (Marc-Andre Lafortune)
* Status: Feedback
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version: 
----------------------------------------
We should have a way to get the list of prepended modules of a class or module.

    module Mixin
    end

    module Outer
      prepend Mixin
    end

    Mixin.prepended_modules   #=> []
    Outer.prepended_modules   #=> [Mixin]

See also bug #8025.

---Files--------------------------------
prepended.pdf (99.4 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:96350] [Ruby master Feature#8026] Need Module#prepended_modules

[mame]

Issue #8026 has been updated by mame (Yusuke Endoh).


Now I'm unsure if the feature is worth adding.  It was accepted six years ago, but not implemented yet.  I've never heard any actual trouble due to the lack.

----------------------------------------
Feature #8026: Need Module#prepended_modules
https://bugs.ruby-lang.org/issues/8026#change-83261

* Author: marcandre (Marc-Andre Lafortune)
* Status: Feedback
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version: 
----------------------------------------
We should have a way to get the list of prepended modules of a class or module.

    module Mixin
    end

    module Outer
      prepend Mixin
    end

    Mixin.prepended_modules   #=> []
    Outer.prepended_modules   #=> [Mixin]

See also bug #8025.

---Files--------------------------------
prepended.pdf (99.4 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:96889] [Ruby master Feature#8026] Need Module#prepended_modules

[matz]

Issue #8026 has been updated by matz (Yukihiro Matsumoto).


I am still OK with the idea (but not for ancestors). `prepended_module` should list direct prepended modules for the receiver.

Matz.


----------------------------------------
Feature #8026: Need Module#prepended_modules
https://bugs.ruby-lang.org/issues/8026#change-83901

* Author: marcandre (Marc-Andre Lafortune)
* Status: Feedback
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version: 
----------------------------------------
We should have a way to get the list of prepended modules of a class or module.

    module Mixin
    end

    module Outer
      prepend Mixin
    end

    Mixin.prepended_modules   #=> []
    Outer.prepended_modules   #=> [Mixin]

See also bug #8025.

---Files--------------------------------
prepended.pdf (99.4 KB)


-- 
https://bugs.ruby-lang.org/