ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: duerst@it.aoyama.ac.jp
To: ruby-core@ruby-lang.org
Subject: [ruby-core:96847] [Ruby master Feature#16233] winruby UTF8 Fallback for no CodePage
Date: Tue, 14 Jan 2020 10:11:39 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-83851.20200114101138.6c11ca0ce0f7bac7@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16233.20191003072936@ruby-lang.org

Issue #16233 has been updated by duerst (Martin Dürst).


Will do, but probably not very soon, because it's now the most busy time of the year at work, sorry.

Some notes: For the encoding (onigX), windows-1256 is a replica of iso-8859-6. But windows-1256 is much more complete, while iso-8859-6 has many unassigned codepoints, so it may be a good idea to fix this if we get around to it.

Just adding an alias 'CP720' for windows-1256 is much easier. 

----------------------------------------
Feature #16233: winruby UTF8 Fallback for no CodePage
https://bugs.ruby-lang.org/issues/16233#change-83851

* Author: gabuscus (Gabriel Nagy)
* Status: Open
* Priority: Normal
* Assignee: duerst (Martin Dürst)
* Target version: 2.8
----------------------------------------
This is to deal specifically with setting the Region to Arabic which
sets the codepage to 720. This codepage isn't recognised by Ruby which
causes it to fail during initialisation when setting up LOCALE.

This patch to Ruby is necessary to handle languages/regions on windows
where the codepage is not supported by Ruby such as Arabic which uses 
codepage 720.
If the codepage is not found, the Locale falls back to UTF8.

This is a well known Ruby/Ruby on Rails issue which is described at
https://stackoverflow.com/questions/22815542/rails4-unknown-encoding-name-cp720

Opened PR: https://github.com/ruby/ruby/pull/2518

---Files--------------------------------
windows_nocodepage_utf8_fallback_r2.5.patch (946 Bytes)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

      parent reply	other threads:[~2020-01-14 10:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-16233.20191003072936@ruby-lang.org>
2019-10-03  7:29 ` [ruby-core:95196] [Ruby master Bug#16233] winruby UTF8 Fallback for no CodePage gabrielnagy
2019-10-04  4:44 ` [ruby-core:95215] " duerst
2019-10-04 11:06 ` [ruby-core:95217] " gabrielnagy
2020-01-14  9:17 ` [ruby-core:96843] [Ruby master Feature#16233] " naruse
2020-01-14 10:11 ` duerst [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-83851.20200114101138.6c11ca0ce0f7bac7@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).