From: nobu@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:96566] [Ruby master Bug#16465] False keyword warning against Struct#initialize
Date: Sun, 29 Dec 2019 08:30:02 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-83504.20191229083001.cf5e2888a8e96f4a@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16465.20191229074951@ruby-lang.org
Issue #16465 has been updated by nobu (Nobuyoshi Nakada).
Your patch seems eventually same as:
```diff
diff --git a/struct.c b/struct.c
index 79131db2bd..07bfe59b97 100644
--- a/struct.c
+++ b/struct.c
@@ -326,9 +326,7 @@ static VALUE
setup_struct(VALUE nstr, VALUE members, int keyword_init)
{
long i, len;
- VALUE (*new_func)(int, const VALUE *, VALUE) = rb_class_new_instance;
-
- if (keyword_init) new_func = struct_new_kw;
+ VALUE (*new_func)(int, const VALUE *, VALUE) = struct_new_kw;
members = struct_set_members(nstr, members);
```
----------------------------------------
Bug #16465: False keyword warning against Struct#initialize
https://bugs.ruby-lang.org/issues/16465#change-83504
* Author: mame (Yusuke Endoh)
* Status: Open
* Priority: Normal
* Assignee: jeremyevans0 (Jeremy Evans)
* Target version:
* ruby -v: ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
The following code is warned:
```ruby
Sample2 = Struct.new(:s1, :s2, :s3) do
def initialize(a1:, a2:)
super(a1, a2, a1 + a2)
end
end
p Sample2.new(a1:1, a2:2)
#=> test.rb:6: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
#=> test.rb:2: warning: The called method `initialize' is defined here
```
I think the code is innocent and the warning is false positive. I'll create a pull request.
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2019-12-29 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-16465.20191229074951@ruby-lang.org>
2019-12-29 7:49 ` [ruby-core:96563] [Ruby master Bug#16465] False keyword warning against Struct#initialize mame
2019-12-29 7:53 ` [ruby-core:96564] " mame
2019-12-29 8:04 ` [ruby-core:96565] " mame
2019-12-29 8:30 ` nobu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-83504.20191229083001.cf5e2888a8e96f4a@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).